Skip to content

Commit fc6bc89

Browse files
authored
Merge pull request #469 from Esri/fix/peer-dependencies
make @esri/arcis-rest-* `peerDependencies` of @esri/cedar
2 parents f7a4bd6 + 10def8a commit fc6bc89

File tree

5 files changed

+15
-5040
lines changed

5 files changed

+15
-5040
lines changed

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,16 @@ You are looking at the documentation for v1.x of cedar. You can also view the [d
2323

2424
You can install cedar and it's [dependencies](#dependencies) from npm:
2525
```bash
26+
npm install @esri/arcgis-rest-feature-layer@^2.0.0
27+
npm install @esri/arcgis-rest-request@^2.0.0
2628
npm install @esri/cedar
2729
```
2830

2931
or yarn:
3032

3133
```bash
34+
yarn add @esri/arcgis-rest-feature-layer@^2.0.0
35+
yarn add @esri/arcgis-rest-request@^2.0.0
3236
yarn add @esri/cedar
3337
```
3438

@@ -164,7 +168,7 @@ You can also see how to use cedar with the [ArcGIS API for JavaScript](https://d
164168

165169
## Dependencies
166170

167-
Cedar isn't yet another JavaScript charting library. Instead, cedar is a very thin wrapper around other libraries that do the heavy lifting. Cedar uses [amCharts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. Cedar also uses [@esri/arcgis-rest-feature-layer](https://esri.github.io/arcgis-rest-js/api/feature-layer/) and [@esri/arcgis-rest-request](https://esri.github.io/arcgis-rest-js/api/request/) to query feature data. You will need to include these libraries along with cedar in your application. If you [install cedar using npm or yarn](#installing-cedar) these libraries will be installed for you, but you will have to make sure that your module bundler can resolve and include them in your application. If you are loading cedar from a CDN, please refer to the [loading cedar](#loading-cedar) section above for the `<script>` tags that you will need to include.
171+
Cedar isn't yet another JavaScript charting library. Instead, cedar is a very thin wrapper around other libraries that do the heavy lifting. Cedar uses [amCharts](https://www.amcharts.com/javascript-charts/) library as it's charting engine. Cedar also uses [@esri/arcgis-rest-feature-layer](https://esri.github.io/arcgis-rest-js/api/feature-layer/) and [@esri/arcgis-rest-request](https://esri.github.io/arcgis-rest-js/api/request/) to query feature data. You will need to [install](#installing-cedar) these libraries along with cedar in your application. If you are loading cedar from a CDN, please refer to the [loading cedar](#loading-cedar) section above for the `<script>` tags that you will need to include.
168172

169173
Cedar supports the [same browsers as ArcGIS Online](https://doc.arcgis.com/en/arcgis-online/reference/browsers.htm), however you may need to include polyfills for [`fetch`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch) and [`Promise`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise), if your application has to support browers that don't support them (i.e. IE or older versions of Safari/Android).
170174

packages/cedar/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
55

66
## [Unreleased]
77

8+
### Fixed
9+
- make @esri/arcis-rest-* `peerDependencies` of @esri/cedar
810
### Changed
911
- update README and CHANGELOG for v1.0.0 release
1012

packages/cedar/package.json

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,12 +64,12 @@
6464
"mapCoverage": true
6565
},
6666
"dependencies": {
67-
"@esri/arcgis-rest-feature-layer": "^2.0.0",
68-
"@esri/arcgis-rest-request": "^2.0.0",
69-
"@esri/arcgis-rest-types": "^2.0.0",
7067
"@esri/cedar-amcharts": "^1.0.0"
7168
},
7269
"devDependencies": {
70+
"@esri/arcgis-rest-feature-layer": "^2.0.0",
71+
"@esri/arcgis-rest-request": "^2.0.0",
72+
"@esri/arcgis-rest-types": "^2.0.0",
7373
"@types/jest": "^23.3.1",
7474
"@types/node": "^10.5.7",
7575
"jest": "^23.5.0",
@@ -85,5 +85,10 @@
8585
"tslint": "^5.5.0",
8686
"typedoc": "^0.13.0",
8787
"typescript": "^3.0.1"
88+
},
89+
"peerDependencies": {
90+
"@esri/arcgis-rest-feature-layer": "^2.0.0",
91+
"@esri/arcgis-rest-request": "^2.0.0",
92+
"@esri/arcgis-rest-types": "^2.0.0"
8893
}
8994
}

0 commit comments

Comments
 (0)