update tests

Author: jmhauck

packages/web-tool/src/web-tool-processor.ts

@@ -277,7 +277,7 @@ export async function getNotebookServerCreateServiceURL(
 ): Promise<string> {
   const notebookUrl = templateDictionary.isPortal
     ? await getNotebookEnterpriseServerRootURL(portalBaseUrl, authentication)
-    : templateDictionary?.portalUrls?.notebooks.https.length > 0
+    : templateDictionary.portalUrls?.notebooks.https.length > 0
       ? templateDictionary.portalUrls.notebooks.https[0]
       : "";
 

packages/web-tool/test/web-tool-processor.test.ts

@@ -153,6 +153,33 @@ describe("Module `web-tool-processor`: ", () => {
       expect(blobToJsonSpy.calls.count()).toBe(1);
     });
 
+    it("can handle error on getEnterpriseServers", async () => {
+      const getEnterpriseServersSpy = spyOn(common, "getEnterpriseServers").and.throwError("error")
+
+      await WebToolProcessor.createItemFromTemplate(
+        {
+          id: "bc3",
+          type: "Geoprocessing Service",
+          item: {
+            typeKeywords: ["Web Tool"],
+            thumbnail: "thumb",
+          },
+          data: {
+            notebookId: "123",
+            name: "NotebookName",
+          },
+        } as any,
+        {
+          isPortal: true
+        },
+        MOCK_USER_SESSION,
+        cb,
+      );
+
+      expect(getEnterpriseServersSpy.calls.count()).toBe(1);
+      expect(getEnterpriseServersSpy).toThrowError();
+    });
+
     it("Web Tool Geoprocessing Service handles cancel with item removal", async () => {
       const createCb2 = () => {
         let calls = 0;
@@ -638,12 +665,100 @@ describe("Module `web-tool-processor`: ", () => {
           type: "Geoprocessing Service",
           item: { typeKeywords: ["Web Tool"] },
         } as any,
-        undefined,
+        {},
         MOCK_USER_SESSION,
       ).then(
         () => fail(),
         (e) => expect(e).toBeUndefined(),
       );
     });
   });
+
+  describe("getNotebookServerCreateServiceURL", () => {
+    it("should fetch servers for Enterprise", async () => {
+      const notebookBaseUrl = "https://RQALnxBI01NB.esri.com/gis";
+      const getEnterpriseServersSpy = spyOn(common, "getEnterpriseServers").and.resolveTo([
+        {
+          "id": "e0d0rP32Fai4ToC3",
+          "name": "RQALnxBI01Sv.esri.com:6443",
+          "adminUrl": "https://RQALnxBI01Sv.esri.com:6443/arcgis",
+          "url": "https://RQALnxBI01Sv.esri.com/gis",
+          "isHosted": true,
+          "serverType": "ArcGIS",
+          "serverRole": "HOSTING_SERVER",
+          "serverFunction": "KnowledgeServer,WorkflowManager"
+        },
+        {
+          "id": "U5yshUHhJkWINozX",
+          "name": "RQALnxBI01NB.esri.com:11443",
+          "adminUrl": "https://RQALnxBI01NB.esri.com:11443/arcgis",
+          "url": notebookBaseUrl,
+          "isHosted": false,
+          "serverType": "ARCGIS_NOTEBOOK_SERVER",
+          "serverRole": "FEDERATED_SERVER",
+          "serverFunction": "NotebookServer"
+        }
+      ]);
+
+      return WebToolProcessor.getNotebookServerCreateServiceURL(
+        "https://gisserver.domain.com/server",
+        MOCK_USER_SESSION,
+        {
+          isPortal: true
+        }
+      ).then(
+        (url) => {
+          expect(getEnterpriseServersSpy.calls.count()).toBe(1);
+          expect(url.startsWith(
+            `${notebookBaseUrl}/admin/services/createService?f=json&request.preventCache=`
+          )).toBe(true);
+        },
+        () => fail(),
+      );
+    });
+
+
+    it("should handle missing Enterprise server", async () => {
+      const getEnterpriseServersSpy = spyOn(common, "getEnterpriseServers").and.resolveTo([
+        {
+          "id": "e0d0rP32Fai4ToC3",
+          "name": "RQALnxBI01Sv.esri.com:6443",
+          "adminUrl": "https://RQALnxBI01Sv.esri.com:6443/arcgis",
+          "url": "https://RQALnxBI01Sv.esri.com/gis",
+          "isHosted": true,
+          "serverType": "ArcGIS",
+          "serverRole": "HOSTING_SERVER",
+          "serverFunction": "KnowledgeServer,WorkflowManager"
+        }
+      ]);
+
+      return WebToolProcessor.getNotebookServerCreateServiceURL(
+        "https://gisserver.domain.com/server",
+        MOCK_USER_SESSION,
+        {
+          isPortal: true
+        }
+      ).then(
+        (url) => {
+          expect(getEnterpriseServersSpy.calls.count()).toBe(1);
+          expect(url).toBe("");
+        },
+        () => fail(),
+      );
+    });
+
+    it("should handle missing portalUrls", async () => {
+      return WebToolProcessor.getNotebookServerCreateServiceURL(
+        "https://gisserver.domain.com/server",
+        MOCK_USER_SESSION,
+        {}
+      ).then(
+        (url) => {
+          expect(url).toBe("");
+        },
+        () => fail(),
+      );
+    });
+
+  });
 });