Protect pets in God mode (with example code). #4522
-
The problemA player's pets can currently receive damage from other players and/or their pets while their owner is in god mode. The ideaTo protect pets that belong to a player from damage (from other players or their pets) if the player is in god mode. But a small problem is...Only pets that belong to an online player can be protected with the code I have created. If the user of an offline player can be fetched if they stay in god mode offline, that's worth changing. An exampleI have already written code for this idea, so here are some screenshots of it in action:
Test build: click here This would probably need:
|
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
|
Great idea. This could be also a separate command to protect all your pets regardless of god mode. |
Beta Was this translation helpful? Give feedback.
-
|
Going to echo my concerns from #4533 here: I appreciate the effort that has gone into the development of the pet protection features in #4533, but I remain unconvinced that this is something we would want to include in EssentialsX itself. Some of the ideas in the PR would work better as a standalone plugin. That said, I wouldn't be completely opposed to a config option to protect pets while in god mode. I would be willing to consider a PR with a smaller scope that covers god mode alone, as suggested in this original issue. |
Beta Was this translation helpful? Give feedback.
Going to echo my concerns from #4533 here:
I appreciate the effort that has gone into the development of the pet protection features in #4533, but I remain unconvinced that this is something we would want to include in EssentialsX itself. Some of the ideas in the PR would work better as a standalone plugin.
That said, I wouldn't be completely opposed to a config option to protect pets while in god mode. I would be willing to consider a PR with a smaller scope that covers god mode alone, as suggested in this original issue.