Fix all clippy warnings, gate v2 bench/tests behind feature flag

Author: Esubaalew

Cargo.toml

@@ -89,6 +89,7 @@ wat = "1.244.0"
 [[bench]]
 name = "run_v2"
 harness = false
+required-features = ["v2"]
 
 [build-dependencies]
 chrono = { version = "0.4", default-features = false, features = ["clock"] }

build.rs

@@ -39,12 +39,10 @@ fn main() {
     if let Ok(rustc_version) = Command::new(env::var("RUSTC").unwrap_or_else(|_| "rustc".into()))
         .arg("--version")
         .output()
+        && rustc_version.status.success()
+        && let Ok(text) = String::from_utf8(rustc_version.stdout)
     {
-        if rustc_version.status.success() {
-            if let Ok(text) = String::from_utf8(rustc_version.stdout) {
-                println!("cargo:rustc-env=RUN_RUSTC_VERSION={}", text.trim());
-            }
-        }
+        println!("cargo:rustc-env=RUN_RUSTC_VERSION={}", text.trim());
     }
 }
 

src/app.rs

@@ -116,7 +116,7 @@ fn execute_once(spec: ExecutionSpec, registry: &LanguageRegistry) -> Result<i32>
     }
 
     // Show timing on stderr if RUN_TIMING=1 or if execution was slow (>1s)
-    let show_timing = std::env::var("RUN_TIMING").map_or(false, |v| v == "1" || v == "true");
+    let show_timing = std::env::var("RUN_TIMING").is_ok_and(|v| v == "1" || v == "true");
     if show_timing || outcome.duration.as_millis() > 1000 {
         eprintln!(
             "\x1b[2m[{} {}ms]\x1b[0m",
@@ -215,7 +215,7 @@ fn bench_run(spec: ExecutionSpec, registry: &LanguageRegistry, iterations: u32)
     let avg = total / times.len() as f64;
     let min = times.first().copied().unwrap_or(0.0);
     let max = times.last().copied().unwrap_or(0.0);
-    let median = if times.len() % 2 == 0 && times.len() >= 2 {
+    let median = if times.len().is_multiple_of(2) && times.len() >= 2 {
         (times[times.len() / 2 - 1] + times[times.len() / 2]) / 2.0
     } else {
         times[times.len() / 2]
@@ -342,12 +342,11 @@ fn resolve_language(
         return Ok(spec);
     }
 
-    if allow_detect {
-        if let Some(payload) = payload {
-            if let Some(detected) = detect_language_for_source(payload, registry) {
-                return Ok(detected);
-            }
-        }
+    if allow_detect
+        && let Some(payload) = payload
+        && let Some(detected) = detect_language_for_source(payload, registry)
+    {
+        return Ok(detected);
     }
 
     let default = LanguageSpec::new(default_language());

src/cli.rs

@@ -90,13 +90,12 @@ pub fn parse() -> Result<Command> {
         .as_ref()
         .map(|value| LanguageSpec::new(value.to_string()));
 
-    if language.is_none() {
-        if let Some(candidate) = trailing.first() {
-            if crate::language::is_language_token(candidate) {
-                let raw = trailing.remove(0);
-                language = Some(LanguageSpec::new(raw));
-            }
-        }
+    if language.is_none()
+        && let Some(candidate) = trailing.first()
+        && crate::language::is_language_token(candidate)
+    {
+        let raw = trailing.remove(0);
+        language = Some(LanguageSpec::new(raw));
     }
 
     let mut source: Option<InputSource> = None;
@@ -113,14 +112,14 @@ pub fn parse() -> Result<Command> {
         source = Some(InputSource::Inline(code));
     }
 
-    if source.is_none() {
-        if let Some(path) = cli.file {
-            ensure!(
-                trailing.is_empty(),
-                "Unexpected positional arguments when --file is present"
-            );
-            source = Some(InputSource::File(path));
-        }
+    if source.is_none()
+        && let Some(path) = cli.file
+    {
+        ensure!(
+            trailing.is_empty(),
+            "Unexpected positional arguments when --file is present"
+        );
+        source = Some(InputSource::File(path));
     }
 
     if source.is_none() && !trailing.is_empty() {

src/config.rs

@@ -29,10 +29,10 @@ impl RunConfig {
         for dir in cwd.ancestors() {
             for name in &["run.toml", ".runrc"] {
                 let candidate = dir.join(name);
-                if candidate.is_file() {
-                    if let Ok(config) = Self::load(&candidate) {
-                        return config;
-                    }
+                if candidate.is_file()
+                    && let Ok(config) = Self::load(&candidate)
+                {
+                    return config;
                 }
             }
         }
@@ -47,20 +47,20 @@ impl RunConfig {
     }
 
     pub fn apply_env(&self) {
-        if let Some(secs) = self.timeout {
-            if std::env::var("RUN_TIMEOUT_SECS").is_err() {
-                // SAFETY: called once at startup before any threads are spawned.
-                unsafe {
-                    std::env::set_var("RUN_TIMEOUT_SECS", secs.to_string());
-                }
+        if let Some(secs) = self.timeout
+            && std::env::var("RUN_TIMEOUT_SECS").is_err()
+        {
+            // SAFETY: called once at startup before any threads are spawned.
+            unsafe {
+                std::env::set_var("RUN_TIMEOUT_SECS", secs.to_string());
             }
         }
-        if let Some(true) = self.timing {
-            if std::env::var("RUN_TIMING").is_err() {
-                // SAFETY: called once at startup before any threads are spawned.
-                unsafe {
-                    std::env::set_var("RUN_TIMING", "1");
-                }
+        if let Some(true) = self.timing
+            && std::env::var("RUN_TIMING").is_err()
+        {
+            // SAFETY: called once at startup before any threads are spawned.
+            unsafe {
+                std::env::set_var("RUN_TIMING", "1");
             }
         }
     }

src/engine/bash.rs

@@ -13,6 +13,12 @@ pub struct BashEngine {
     executable: PathBuf,
 }
 
+impl Default for BashEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl BashEngine {
     pub fn new() -> Self {
         let executable = resolve_bash_binary();

src/engine/c.rs

@@ -16,6 +16,12 @@ pub struct CEngine {
     compiler: Option<PathBuf>,
 }
 
+impl Default for CEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl CEngine {
     pub fn new() -> Self {
         Self {
@@ -88,8 +94,8 @@ impl CEngine {
         let mut path = dir.join("run_c_binary");
         let suffix = std::env::consts::EXE_SUFFIX;
         if !suffix.is_empty() {
-            if suffix.starts_with('.') {
-                path.set_extension(&suffix[1..]);
+            if let Some(stripped) = suffix.strip_prefix('.') {
+                path.set_extension(stripped);
             } else {
                 path = PathBuf::from(format!("{}{}", path.display(), suffix));
             }
@@ -928,7 +934,7 @@ fn is_item_snippet(code: &str) -> bool {
 
     if trimmed.ends_with(';') {
         if trimmed.contains('(') && trimmed.contains(')') {
-            let before_paren = trimmed.splitn(2, '(').next().unwrap_or_default();
+            let before_paren = trimmed.split('(').next().unwrap_or_default();
             if before_paren.split_whitespace().count() >= 2 {
                 return true;
             }
@@ -939,7 +945,7 @@ fn is_item_snippet(code: &str) -> bool {
             "auto", "register", "signed", "unsigned", "short", "long", "int", "char", "float",
             "double", "_Bool", "void",
         ];
-        if TYPE_PREFIXES.iter().any(|kw| first_token == *kw) {
+        if TYPE_PREFIXES.contains(&first_token) {
             return true;
         }
     }

src/engine/cpp.rs

@@ -15,6 +15,12 @@ pub struct CppEngine {
     compiler: Option<PathBuf>,
 }
 
+impl Default for CppEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl CppEngine {
     pub fn new() -> Self {
         Self {
@@ -86,8 +92,8 @@ impl CppEngine {
         let mut path = dir.join("run_cpp_binary");
         let suffix = std::env::consts::EXE_SUFFIX;
         if !suffix.is_empty() {
-            if suffix.starts_with('.') {
-                path.set_extension(&suffix[1..]);
+            if let Some(stripped) = suffix.strip_prefix('.') {
+                path.set_extension(stripped);
             } else {
                 path = PathBuf::from(format!("{}{}", path.display(), suffix));
             }

src/engine/crystal.rs

@@ -12,6 +12,12 @@ pub struct CrystalEngine {
     executable: Option<PathBuf>,
 }
 
+impl Default for CrystalEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl CrystalEngine {
     pub fn new() -> Self {
         Self {

src/engine/csharp.rs

@@ -13,6 +13,12 @@ pub struct CSharpEngine {
     target_framework: Option<String>,
 }
 
+impl Default for CSharpEngine {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl CSharpEngine {
     pub fn new() -> Self {
         let runtime = resolve_dotnet_runtime();