Skip to content

Commit 1268ea4

Browse files
RollczivLuckyyygemini-code-assist[bot]
authored
GH-902 Rename private chat domain to msg. Add migration's for config keys. (#1100)
* privatechat -> msg * Fix migration's. * Update eternalcore-api-example/src/main/java/com/eternalcode/example/feature/privatechat/ApiPrivateChatListener.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update eternalcore-api-example/src/main/java/com/eternalcode/example/feature/privatechat/ApiPrivateChatListener.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix. --------- Co-authored-by: vLuckyyy <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 91ee0ae commit 1268ea4

30 files changed

+250
-212
lines changed

eternalcore-api-example/src/main/java/com/eternalcode/example/feature/privatechat/ApiPrivateChatListener.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.eternalcode.example.feature.privatechat;
22

3-
import com.eternalcode.core.feature.privatechat.PrivateChatEvent;
3+
import com.eternalcode.core.feature.msg.MsgEvent;
44
import java.util.UUID;
55
import org.bukkit.Server;
66
import org.bukkit.entity.Player;
@@ -16,7 +16,7 @@ public ApiPrivateChatListener(Server server) {
1616
}
1717

1818
@EventHandler
19-
public void onPrivateChat(PrivateChatEvent event) {
19+
public void onMsg(MsgEvent event) {
2020
UUID sender = event.getSender();
2121
UUID receiver = event.getReceiver();
2222
String content = event.getContent();
@@ -34,7 +34,7 @@ public void onPrivateChat(PrivateChatEvent event) {
3434
}
3535

3636
@EventHandler
37-
public void overridePrivateChat(PrivateChatEvent event) {
37+
public void overrideMsg(MsgEvent event) {
3838
String content = event.getContent();
3939

4040
if (content.contains("kurła!")) {

eternalcore-api/src/main/java/com/eternalcode/core/EternalCoreApi.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import com.eternalcode.core.feature.home.HomeService;
66
import com.eternalcode.core.feature.jail.JailService;
77
import com.eternalcode.core.feature.language.LanguageService;
8-
import com.eternalcode.core.feature.privatechat.PrivateChatService;
8+
import com.eternalcode.core.feature.msg.MsgService;
99
import com.eternalcode.core.feature.ignore.IgnoreService;
1010
import com.eternalcode.core.feature.randomteleport.RandomTeleportService;
1111
import com.eternalcode.core.feature.spawn.SpawnService;
@@ -26,7 +26,7 @@ public interface EternalCoreApi {
2626

2727
LanguageService getLanguageService();
2828

29-
PrivateChatService getPrivateChatService();
29+
MsgService getMsgService();
3030

3131
RandomTeleportService getRandomTeleportService();
3232

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.eternalcode.core.feature.privatechat;
1+
package com.eternalcode.core.feature.msg;
22

33
import java.util.UUID;
44
import org.bukkit.event.Event;
@@ -7,15 +7,15 @@
77
/**
88
* Event that is called when a player sends a private message to another player.
99
*/
10-
public class PrivateChatEvent extends Event {
10+
public class MsgEvent extends Event {
1111

1212
private static final HandlerList HANDLER_LIST = new HandlerList();
1313

1414
private final UUID sender;
1515
private final UUID receiver;
1616
private String content;
1717

18-
public PrivateChatEvent(UUID sender, UUID receiver, String content) {
18+
public MsgEvent(UUID sender, UUID receiver, String content) {
1919
super(true);
2020

2121
this.sender = sender;
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
package com.eternalcode.core.feature.privatechat;
1+
package com.eternalcode.core.feature.msg;
22

33
import java.util.UUID;
44
import org.bukkit.entity.Player;
55

6-
public interface PrivateChatService {
6+
public interface MsgService {
77

88
void enableSpy(UUID uuid);
99

@@ -13,5 +13,5 @@ public interface PrivateChatService {
1313

1414
void reply(Player sender, String message);
1515

16-
void privateMessage(Player sender, Player target, String message);
16+
void sendMessage(Player sender, Player target, String message);
1717
}
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
1-
package com.eternalcode.core.feature.privatechat.toggle;
1+
package com.eternalcode.core.feature.msg.toggle;
22

33
/**
44
* Enum representing state of blocking incoming private messages by the player.
55
*/
6-
public enum PrivateChatState {
6+
public enum MsgState {
77

88
/**
99
* Player can receive private messages.
1010
*/
11-
ENABLE,
11+
ENABLED,
1212

1313
/**
1414
* Player cannot receive private messages.
1515
*/
16-
DISABLE;
16+
DISABLED;
1717

18-
PrivateChatState invert() {
19-
return this == ENABLE ? DISABLE : ENABLE;
18+
MsgState invert() {
19+
return this == ENABLED ? DISABLED : ENABLED;
2020
}
2121

2222
}
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,28 @@
1-
package com.eternalcode.core.feature.privatechat.toggle;
1+
package com.eternalcode.core.feature.msg.toggle;
22

33
import java.util.UUID;
44
import java.util.concurrent.CompletableFuture;
55

66
/**
77
* This Service manages player's receiving of private messages
88
*/
9-
public interface PrivateChatStateService {
9+
public interface MsgToggleService {
1010

1111
/**
1212
* Checks status of player's private chat messages blocking.
1313
*
1414
* @param playerUniqueId player's UUID.
1515
* @return state of player's private chat messages blocking.
1616
*/
17-
CompletableFuture<PrivateChatState> getChatState(UUID playerUniqueId);
17+
CompletableFuture<MsgState> getState(UUID playerUniqueId);
1818

1919
/**
2020
* Sets blocking of incoming private messages.
2121
*
2222
* @param playerUniqueId player's UUID.
2323
* @param state desired state of player's private chat messages blocking.
2424
*/
25-
CompletableFuture<Void> setChatState(UUID playerUniqueId, PrivateChatState state);
25+
CompletableFuture<Void> setState(UUID playerUniqueId, MsgState state);
2626

2727

2828
/**
@@ -31,6 +31,6 @@ public interface PrivateChatStateService {
3131
* @param playerUniqueId player's UUID.
3232
* @return new state of player's private chat messages blocking.
3333
*/
34-
CompletableFuture<PrivateChatState> toggleChatState(UUID playerUniqueId);
34+
CompletableFuture<MsgState> toggleState(UUID playerUniqueId);
3535

3636
}

eternalcore-core/src/main/java/com/eternalcode/core/EternalCoreApiImpl.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import com.eternalcode.core.feature.ignore.IgnoreService;
77
import com.eternalcode.core.feature.jail.JailService;
88
import com.eternalcode.core.feature.language.LanguageService;
9-
import com.eternalcode.core.feature.privatechat.PrivateChatService;
9+
import com.eternalcode.core.feature.msg.MsgService;
1010
import com.eternalcode.core.feature.randomteleport.RandomTeleportService;
1111
import com.eternalcode.core.feature.spawn.SpawnService;
1212
import com.eternalcode.core.feature.teleport.TeleportService;
@@ -52,8 +52,8 @@ public LanguageService getLanguageService() {
5252
}
5353

5454
@Override
55-
public PrivateChatService getPrivateChatService() {
56-
return this.dependencyProvider.getDependency(PrivateChatService.class);
55+
public MsgService getMsgService() {
56+
return this.dependencyProvider.getDependency(MsgService.class);
5757
}
5858

5959
@Override

eternalcore-core/src/main/java/com/eternalcode/core/configuration/ConfigurationManager.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package com.eternalcode.core.configuration;
22

3+
import com.eternalcode.core.configuration.migrations.Migrations;
34
import com.eternalcode.core.configuration.serializer.LanguageSerializer;
45
import com.eternalcode.core.configuration.transformer.PositionTransformer;
56
import com.eternalcode.core.injector.annotations.Inject;
67
import com.eternalcode.core.injector.annotations.component.Service;
78
import com.eternalcode.core.publish.Publisher;
89
import com.eternalcode.multification.notice.resolver.NoticeResolverRegistry;
910
import com.eternalcode.multification.okaeri.MultificationNoticeSerializer;
11+
import eu.okaeri.configs.ConfigManager;
1012
import eu.okaeri.configs.OkaeriConfig;
1113
import eu.okaeri.configs.serdes.OkaeriSerdesPack;
1214
import eu.okaeri.configs.serdes.commons.SerdesCommons;
@@ -15,6 +17,7 @@
1517
import java.util.Collections;
1618
import java.util.HashSet;
1719
import java.util.Set;
20+
import java.util.logging.Logger;
1821
import org.yaml.snakeyaml.DumperOptions;
1922
import org.yaml.snakeyaml.LoaderOptions;
2023
import org.yaml.snakeyaml.Yaml;
@@ -61,9 +64,10 @@ public <T extends OkaeriConfig & EternalConfigurationFile> T load(T config) {
6164
config.withConfigurer(yamlConfigurer)
6265
.withSerdesPack(serdesPack)
6366
.withBindFile(file)
64-
.withRemoveOrphans(true)
6567
.saveDefaults()
66-
.load(true);
68+
.load(true)
69+
.migrate(Migrations.ALL); // Remember: migration should be launched after the #load method.
70+
6771

6872
this.configs.add(config);
6973
return config;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package com.eternalcode.core.configuration.migrations;
2+
3+
import static eu.okaeri.configs.migrate.ConfigMigrationDsl.move;
4+
import eu.okaeri.configs.migrate.builtin.NamedMigration;
5+
6+
class Migration_0001_Rename_privateChat_to_msg extends NamedMigration {
7+
8+
Migration_0001_Rename_privateChat_to_msg() {
9+
super("Rename privateChat to msg",
10+
move("privateChat.privateMessageYouToTarget", "privateChat.msgYouToTarget"),
11+
move("privateChat.privateMessageTargetToYou", "privateChat.msgTargetToYou"),
12+
move("privateChat", "msg")
13+
);
14+
}
15+
16+
}
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package com.eternalcode.core.configuration.migrations;
2+
3+
import eu.okaeri.configs.migrate.ConfigMigration;
4+
5+
public class Migrations {
6+
7+
public static final ConfigMigration[] ALL = new ConfigMigration[] {
8+
new Migration_0001_Rename_privateChat_to_msg(),
9+
};
10+
11+
}

0 commit comments

Comments
 (0)