GH-897 Fix dependency injector configuration class instance handling of plugin config (#897)

* innit

* Fix logic, add additional comments to clarify the usage.

* Another fix

* Fix configuration not supplying for Beans

* Rollback logic for rtp

* Rollback rtp config

Author: CitralFlo

eternalcore-core/src/main/java/com/eternalcode/core/EternalCore.java

@@ -1,6 +1,8 @@
 package com.eternalcode.core;
 
 import com.eternalcode.core.compatibility.CompatibilityService;
+import com.eternalcode.core.configuration.ReloadableConfig;
+import com.eternalcode.core.configuration.compatibility.ConfigurationCompatibilityV21_2;
 import com.eternalcode.core.injector.DependencyInjector;
 import com.eternalcode.core.injector.annotations.component.Component;
 import com.eternalcode.core.injector.annotations.component.ConfigurationFile;
@@ -78,6 +80,8 @@ public EternalCore(Plugin plugin) {
             beanFactory.addCandidate(beanCandidate);
         }
 
+        beanFactory.initializeCandidates(ConfigurationCompatibilityV21_2.class); // TODO: Remove this when the cdn will be fixed
+        beanFactory.initializeCandidates(ReloadableConfig.class); // TODO: Remove this when the cdn will be fixed
         beanFactory.initializeCandidates();
 
         this.publisher = beanFactory.getDependency(Publisher.class);

eternalcore-core/src/main/java/com/eternalcode/core/configuration/compatibility/ConfigurationCompatibilityV21_2.java

@@ -7,9 +7,10 @@
 import com.eternalcode.core.injector.annotations.component.Controller;
 import com.eternalcode.core.publish.Subscribe;
 
+// TODO: Make this package private
 @Controller
 @Compatibility(from = @Version(minor = 21, patch = 2))
-class ConfigurationCompatibilityV21_2 {
+public class ConfigurationCompatibilityV21_2 {
 
     @Subscribe
     void onConfigSettingsSetup(ConfigurationSettingsSetupEvent event) {

eternalcore-core/src/main/java/com/eternalcode/core/feature/randomteleport/RandomTeleportSettingsImpl.java

@@ -31,7 +31,7 @@ public class RandomTeleportSettingsImpl implements RandomTeleportSettings, Migra
         "# If you want to use a static radius, set the type to STATIC_RADIUS and set the radius here.",
         "# If you using WORLD_BORDER_RADIUS, this value will be ignored."
     })
-    public RandomTeleportRadiusConfig radius = new RandomTeleportRadiusConfig(5000, 5000, 5000, 5000);
+    public RandomTeleportRadiusConfig radius = new RandomTeleportRadiusConfig(-5000, 5000, -5000, 5000);
     @Deprecated public Integer randomTeleportRadius = null;
 
     @Description("# Teleport to a specific world, if left empty it will teleport to the player's current world")

eternalcore-core/src/main/java/com/eternalcode/core/feature/randomteleport/RandomTeleportTaskService.java

@@ -42,10 +42,9 @@ class RandomTeleportTaskService {
 
     CompletableFuture<RandomTeleportResult> createTeleport(Player player) {
         World world = resolveWorld(player, randomTeleportSettings);
-        RandomTeleportRadius radius = this.randomTeleportSettings.radius();
         return this.randomTeleportSafeLocationService.getSafeRandomLocation(
             world,
-            radius,
+            this.randomTeleportSettings.radius(),
             this.randomTeleportSettings.teleportAttempts()
         ).thenCompose(location -> this.createTeleport(player, location));
     }

eternalcore-core/src/main/java/com/eternalcode/core/injector/bean/LazyBeanCandidate.java

@@ -15,9 +15,7 @@ public LazyBeanCandidate(String name, Supplier<Object> instanceSupplier) {
 
     @Override
     public boolean isCandidate(Class<?> clazz) {
-        Class<?> type = this.getInstance().getClass();
-
-        return clazz.isAssignableFrom(type);
+        return clazz.isAssignableFrom(getType());
     }
 
     @Override

eternalcore-core/src/main/java/com/eternalcode/core/injector/bean/LazyFieldBeanCandidate.java

@@ -28,7 +28,7 @@ public LazyFieldBeanCandidate(Supplier<Object> instance, Field field, Bean bean)
     }
 
     public LazyFieldBeanCandidate(DependencyInjector dependencyInjector, Class<?> componentClass, Field field, Bean bean) {
-        this(() -> dependencyInjector.newInstance(componentClass), field, bean);
+        this(() -> dependencyInjector.getDependencyProvider().getDependency(componentClass), field, bean);
     }
 
     @Override