Skip to content

GH-991 Add MOTD feature #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 11, 2025
Merged

GH-991 Add MOTD feature #1094

merged 9 commits into from
Aug 11, 2025

Conversation

Jakubk15
Copy link
Member

@Jakubk15 Jakubk15 commented Aug 7, 2025

No description provided.

@Jakubk15 Jakubk15 requested a review from a team as a code owner August 7, 2025 19:31
@Jakubk15 Jakubk15 added the 🆕 feature New feature or request label Aug 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2025 •
edited
Loading

📦 Development Build Ready

Warning

Do not use this build in production. It is for testing purposes only and may be unstable.

👉 Click here to download the JAR

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Message of the Day (MOTD) feature, which displays a configurable message to players when they join the server. The implementation is well-structured, adding new configuration classes, integrating them into the main plugin configuration, and creating a controller to handle the PlayerJoinEvent. My review includes one suggestion for PlayerJoinMotdController to replace hardcoded placeholder strings with constants to improve code maintainability.

@Jakubk15 Jakubk15 linked an issue Aug 8, 2025 that may be closed by this pull request
MOTD message on player join (in chat) #991
Closed
@Jakubk15 Jakubk15 changed the title Add MOTD feature GH-991 Add MOTD feature Aug 8, 2025
P1otrulla
P1otrulla approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@P1otrulla P1otrulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is great, but I would change the name to something other than motd, it will confuse players in the configuration with MOTD from the server selection

@Jakubk15
Copy link
Member Author

Everything is great, but I would change the name to something other than motd, it will confuse players in the configuration with MOTD from the server selection

Any ideas for the name?

@vLuckyyy vLuckyyy merged commit da1a20f into master Aug 11, 2025
2 checks passed
@vLuckyyy vLuckyyy deleted the motd branch August 11, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vLuckyyy vLuckyyy vLuckyyy approved these changes

@P1otrulla P1otrulla P1otrulla approved these changes

@CitralFlo CitralFlo CitralFlo approved these changes

@imDMK imDMK imDMK approved these changes

@Rollczi Rollczi Awaiting requested review from Rollczi

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
🆕 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MOTD message on player join (in chat)
5 participants
@Jakubk15 @vLuckyyy @P1otrulla @CitralFlo @imDMK