Return proper exceptions when uploading big profile pictures (#1324)

* Return proper exceptions when uploading big profile pictures

* Handle Attributerror since images are not required

* Add alert in the html page

* Update limit to FILE_UPLOAD_MAX_MEMORY_SIZE

Author: Sangarshanan

conference/user_panel.py

@@ -6,6 +6,7 @@
 from model_utils import Choices
 
 from django import forms
+from django.conf import settings
 from django.conf.urls import url as re_path
 from django.contrib import messages
 from django.contrib.auth import views as auth_views
@@ -474,6 +475,15 @@ def clean_twitter(self):
 
         return data
 
+    def clean_image(self):
+        data = self.cleaned_data.get("image")
+        try:
+            if data.size > settings.PROFILE_PICTURE_MAX_SIZE:
+                raise forms.ValidationError("Profile picture too large ( > 2.5mb )")
+        except AttributeError:
+            pass
+        return data
+
     def resolve_image_settings(self, selected_option, image_url, image):
         if selected_option == PICTURE_CHOICES.gravatar:
             image = None

pycon/settings.py

@@ -59,6 +59,8 @@ def _(x):
 
 SITE_DATA_ROOT = DATA_DIR + "/site"
 
+PROFILE_PICTURE_MAX_SIZE = 2621440
+
 # DATABASE
 # --------
 DATABASES = {

templates/conference/user_panel/profile_settings.html

@@ -13,6 +13,15 @@
 <div class='row' style='margin-top: 3em'>
 
     <div class="col-md-12">
+        {% if profile_form.errors %}
+            {% for field in profile_form %}
+                {% for error in field.errors %}
+                <div class="alert alert-danger">
+                    {{ error|escape }}
+                </div>
+                {% endfor %}
+            {% endfor %}
+        {% endif %}
         <form method="POST" action="." enctype="multipart/form-data">
             {% csrf_token %}
             {% crispy profile_form %}