review feedback

Author: artcz

Makefile

@@ -58,9 +58,11 @@ worker:
 test:
 	$(TEST_CMD) -s -v
 
-test_:
+test_last_failed:
 	$(TEST_CMD) -s -v --last-failed
 
+test_: test_last_failed
+
 test/k:
 	$(TEST_CMD) -s -v -k $(K)
 

intbot/core/endpoints/webhooks.py

@@ -23,6 +23,8 @@ def internal_webhook_endpoint(request):
             content=json.loads(request.body),
             extra={},
         )
+        # Schedule a task for the worker to process the webhook outside of
+        # request/response cycle.
         process_webhook.enqueue(str(wh.uuid))
 
         return JsonResponse({"status": "created", "guid": wh.uuid})
@@ -45,22 +47,24 @@ def verify_internal_webhook(request):
 @csrf_exempt
 def github_webhook_endpoint(request):
     if request.method == "POST":
-        github_headers = {
-            k: v for k, v in request.headers.items() if k.startswith("X-Github")
-        }
-
         try:
             signature = verify_github_signature(request)
         except ValueError as e:
             return HttpResponseForbidden(e)
 
+        github_headers = {
+            k: v for k, v in request.headers.items() if k.startswith("X-Github")
+        }
+
         wh = Webhook.objects.create(
             source="github",
             meta=github_headers,
             signature=signature,
             content=json.loads(request.body),
             extra={},
         )
+        # Schedule a task for the worker to process the webhook outside of
+        # request/response cycle.
         process_webhook.enqueue(str(wh.uuid))
         return JsonResponse({"status": "created", "guid": wh.uuid})
 
@@ -92,26 +96,27 @@ def verify_github_signature(request) -> str:
 @csrf_exempt
 def zammad_webhook_endpoint(request):
     if request.method == "POST":
-        zammad_headers = {
-            k: v for k, v in request.headers.items() if k.startswith("X-Zammad")
-        }
-
         try:
             signature = verify_zammad_signature(request)
         except ValueError as e:
             return HttpResponseForbidden(e)
 
+        zammad_headers = {
+            k: v for k, v in request.headers.items() if k.startswith("X-Zammad")
+        }
+
         wh = Webhook.objects.create(
             source="zammad",
             meta=zammad_headers,
             signature=signature,
             content=json.loads(request.body),
             extra={},
         )
+        # Schedule a task for the worker to process the webhook outside of
+        # request/response cycle.
         process_webhook.enqueue(str(wh.uuid))
         return JsonResponse({"status": "created", "guid": wh.uuid})
 
-
     return HttpResponseNotAllowed("Only POST")