Skip to content

Conversation

@Cheukting
Copy link
Contributor

No description provided.

@Cheukting
Copy link
Contributor Author

@rodrigogiraoserrao seems I do not have the right SSH key to run the preview

@rodrigogiraoserrao
Copy link
Contributor

@rodrigogiraoserrao seems I do not have the right SSH key to run the preview

No idea what this is/how to fix it.

@egeakman sorry to rope you in, but do you have any idea what this issue with the preview is?

@cybit
Copy link
Contributor

cybit commented Feb 27, 2025

@Cheukting @rodrigogiraoserrao The reason is simple.

This PR is based on a fork that is not in the EPS repository. The system to create the previews does need a secret that is only accessible within the EPS repos.
Access to any secret for other repositories is most likely a bad idea in most cases and therefore forbidden by GitHub. (Secret exposure, execution of malicious code)

Had the PR been based on a branch of EuroPython/website the secret would be available and everything works as expected.

@rodrigogiraoserrao
Copy link
Contributor

@Cheukting @rodrigogiraoserrao The reason is simple.

This PR is based on a fork that is not in the EPS repository. The system to create the previews does need a secret that is only accessible within the EPS repos. Access to any secret for other repositories is most likely a bad idea in most cases and therefore forbidden by GitHub. (Secret exposure, execution of malicious code)

Had the PR been based on a branch of EuroPython/website the secret would be available and everything works as expected.

Thanks for the explanation! Opened #1023 so we can see the preview before merging.

@Cheukting
Copy link
Contributor Author

Cheukting commented Feb 28, 2025 via email

@hypha
Copy link
Contributor

hypha commented Feb 28, 2025

@Cheukting for future references, you do have access to the EP repo ☺️

rodrigogiraoserrao added a commit that referenced this pull request Mar 3, 2025
Essentially a copy of #1022 but so that we could see the preview.

---------

Co-authored-by: Cheukting <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants