Added initial content for finaid page #1028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Preview available
|
vellankikoti
changed the title
thepetk
reviewed
Mar 6, 2025
Contributor
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
Awesome work <3 I've left some comments/questions I had!
| non-transferable. | ||
|
|
||
| - You must accept a grant offer before the relevant acceptance deadline stated | ||
| in the timeline. The grant offer will expire otherwise. |
Contributor
There was a problem hiding this comment.
nit: We could link the timeline section here
Contributor
Author
There was a problem hiding this comment.
okay, I'll try to add the timeline here
hypha
reviewed
Mar 6, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Thanks so much for working on this! Left a few small comments.
Things not in diff:
- Would you mind adding it to the menu? It'd be here: https://github.com/EuroPython/website/blob/ep2025-finaid/src/data/links.json
- Would you mind marking the launch of finaid in the faq milestone?
website/src/content/pages/faq.mdx
Line 23 in 41177c4
- Could you also update the finaid section here in the faq?
website/src/content/pages/faq.mdx
Line 91 in 41177c4
- lastly, if possible, perhaps replace the community voting Call to Action card on the homepage with Finaid? The readme covers how to do it: https://github.com/EuroPython/website/tree/ep2025-finaid?tab=readme-ov-file#deadlines You could check here to see what was done in 2024 https://github.com/EuroPython/website/blob/ep2024/src/content/deadlines/00_finaid.mdx :)
Co-authored-by: hypha <[email protected]>
Co-authored-by: hypha <[email protected]>
Co-authored-by: hypha <[email protected]>
hypha
reviewed
Mar 6, 2025
hypha
approved these changes
Mar 8, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Thanks for working on this. Will address the pending comments in about patch :)
Merged
hypha
added a commit
that referenced
this pull request
Mar 10, 2025
Patch to address some minor things raised in #1028 and internal chat. I’ve removed the references to application rounds in the FAQ, as such details are better kept on the main Finaid page. The FAQ now just provides top-line information on when the Finaid starts and ends, keeping it simple for applicants. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.