Add manual trigger to RTD preview, run workflow on forks. #1083
Conversation
Preview available
|
nikoshell
changed the title
|
|
||
| jobs: | ||
| documentation-links: | ||
| if: github.event.pull_request.head.repo.fork == true |
There was a problem hiding this comment.
We were talking about entirely moving to RTD for previews. I think we can just remove preview.yml.
@artcz thoughts?
There was a problem hiding this comment.
RTD is failing right now with undefined reason and it's blocking few PR.
this change keep current preview which is working fine for pull requests and use RTP for forks.
There was a problem hiding this comment.
Yes, some of the builds are failing – the speaker one is because of the pipx missing (which maybe we should migrate to uvx :D), but the other one doesn't have an obvious reason in the output.
I think it might be a good idea to keep RTD preview just for forks, because that way we also don't overload the RTD servers with unnecessary previews, plus we're testing closer to the same setup as production if we keep the same preview flow.
Looking at our server, so far we generated ~350 previews totalling 6.5G in the last ~two months.
🖼️ Preview available 🖼️ : https://ep-website--1083.org.readthedocs.build/