-
Notifications
You must be signed in to change notification settings - Fork 72
Update loadData function. #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
606dfd7
Update loadData function.
nikoshell e740851
Merge branch 'ep2025' into ep2025-loaddata
nikoshell 6931ee8
Merge branch 'ep2025' into ep2025-loaddata
nikoshell 3268870
Update logging meggeges.
nikoshell 768921c
Add cache for the same fetch urls.
nikoshell 19a2cd5
Add in-flight cache.
nikoshell dcbea04
Merge branch 'ep2025' into ep2025-loaddata
nikoshell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,47 @@ | ||
| export async function loadData(apiUrl: any) { | ||
| export async function loadData( | ||
| apiUrl: string, | ||
| maxRetries = 3, | ||
| retryDelay = 1000 | ||
| ): Promise<any> { | ||
| if (!apiUrl) { | ||
| console.warn(`No API URL provided`); | ||
| return {}; | ||
| throw new Error(`No API URL provided`); | ||
| } | ||
|
|
||
| try { | ||
| console.log(`Fetching data from: ${apiUrl}`); | ||
| const response = await fetch(apiUrl); | ||
| for (let attempt = 1; attempt <= maxRetries; attempt++) { | ||
| try { | ||
| console.log(`Fetching data from: ${apiUrl} (Attempt ${attempt})`); | ||
| const response = await fetch(apiUrl); | ||
|
|
||
| if (!response.ok) { | ||
| throw new Error( | ||
| `Failed to fetch data: ${response.status} ${response.statusText}` | ||
| ); | ||
| } | ||
| if (!response.ok) { | ||
| throw new Error( | ||
| `Fetch failed: ${response.status} ${response.statusText}` | ||
| ); | ||
| } | ||
|
|
||
| const data = await response.json(); | ||
|
|
||
| if ( | ||
| data == null || | ||
| (typeof data === "object" && | ||
| !Array.isArray(data) && | ||
| Object.keys(data).length === 0) | ||
| ) { | ||
| throw new Error(`Received empty or invalid JSON`); | ||
| } | ||
|
|
||
| return await response.json(); | ||
| } catch (error) { | ||
| console.error(`Error loading data:`, error); | ||
| return {}; | ||
| return data; | ||
| } catch (error) { | ||
| console.error(`Attempt ${attempt} failed:`, error); | ||
|
|
||
| if (attempt < maxRetries) { | ||
| await new Promise((res) => setTimeout(res, retryDelay)); | ||
| } else { | ||
| throw new Error( | ||
| `Failed to load data from ${apiUrl} after ${maxRetries} attempts` | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| throw new Error(`Unexpected execution path`); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.