Skip to content

Conversation

@clytaemnestra
Copy link
Contributor

No description provided.

@europython-society
Copy link
Member

europython-society commented May 11, 2025

Preview available

Key Value
url https://ep2025-about-us-2.ep-preview.click
last update 2025-05-14T22:16:36.135Z

@clytaemnestra clytaemnestra marked this pull request as draft May 11, 2025 16:03
Copy link
Contributor

@nikoshell nikoshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use md in some case can be mdx, if it must be mdx pls use / create astro components instead of huge html block. If html source is bigger then md, we should create astro page.

Other way it will be hard to maintain.

In this case with this content md file will be good.

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the infra team too too and have special mention of people like Ege and Marcin.

@clytaemnestra
Copy link
Contributor Author

Hey @hypha thanks a lot for the feedback! The PR is still a draft, I just copied names from the onboarding spreadsheet, so I'm aware that I was missing some people. I've addressed all your remarks and hopefully, I didn't miss anyone 🙂

@clytaemnestra clytaemnestra marked this pull request as ready for review May 13, 2025 12:02
@clytaemnestra clytaemnestra requested review from artcz and hypha May 13, 2025 12:07
Co-authored-by: Theofanis Petkos <[email protected]>
Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mia! A few suggestions:

Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One wee suggestion :)

@clytaemnestra
Copy link
Contributor Author

alright, thank you everyone for your feedback, I've addressed all the notes - can I merge the PR?

@clytaemnestra clytaemnestra removed the request for review from nikoshell May 14, 2025 16:12
this was my bad!

Co-authored-by: Theofanis Petkos <[email protected]>
Copy link
Contributor

@hypha hypha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 to all

Co-authored-by: Theofanis Petkos <[email protected]>
@clytaemnestra clytaemnestra merged commit 5c1f64a into ep2025 May 14, 2025
3 of 5 checks passed
@clytaemnestra clytaemnestra deleted the ep2025-about-us-2 branch May 14, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants