Clean up #1232
Merged
Clean up #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
clytaemnestra
approved these changes
May 15, 2025
Comment on lines
+1
to
+10
| <Fragment is:raw> | ||
| <iframe | ||
| src="https://www.google.com/maps/embed?pb=!1m14!1m8!1m3!1d10245.064741908278!2d14.4290206!3d50.0625764!3m2!1i1024!2i768!4f13.1!3m3!1m2!1s0x0%3A0x4d26855708eb61f7!2sPrague%20Congress%20Centre!5e0!3m2!1sen!2suk!4v1676555813425!5m2!1sen!2suk" | ||
| title="Map" | ||
| className="w-full aspect-video max-w-[800px] border-4 border-white rounded-lg shadow-lg" | ||
| allowFullScreen={true} | ||
| class="w-full aspect-video max-w-[800px] border-4 border-white rounded-lg shadow-lg" | ||
| allowFullScreen="true" | ||
| loading="lazy" | ||
| referrerPolicy="no-referrer-when-downgrade" | ||
| ></iframe> | ||
| ); | ||
| </Fragment> |
Contributor
There was a problem hiding this comment.
FYI I updated this in another PR: https://github.com/EuroPython/website/pull/1227/files#diff-d7d44fd3cc527b8dbcaa8b661a0eb769d94080a4ae4fccc535320ffdc9fa5fefR1
We need to have the component map generic and be able to pass coordinates from google maps, so it's reusable at multiple places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up in the code and components, content and design should not be affected.
In some place we replace old icons. For example hero section on main page.
We need some clean up before Tailwind 4 upgrade and adding Astro compress.
There will be part 2 of clean up just to split PRs.