Skip to content

Clean up #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 15, 2025
Merged

Clean up #1232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0a42e80
Cleanup: Hero and finaid.
nikoshell May 15, 2025
d028f4b
Clean up: ButtonLink and md file.
nikoshell May 15, 2025
206fc18
Clean up icons.
nikoshell May 15, 2025
c040d6e
Clean up: move hero to sections.
nikoshell May 15, 2025
7848ad7
Clean up: remove nav-items.
nikoshell May 15, 2025
d42de3b
Clean up: separator.
nikoshell May 15, 2025
6cbcaec
Clean up: remove old separator.
nikoshell May 15, 2025
ca3e2d6
Clean up: 404 and fullbleed.
nikoshell May 15, 2025
634a03a
Clean up: fullbleed styles.
nikoshell May 15, 2025
d66423f
Clean up: assets.
nikoshell May 15, 2025
97cf58d
Clean up: Unused components.
nikoshell May 15, 2025
f3719fd
Clean up: Cards.
nikoshell May 15, 2025
2be786f
Clean up: Hero icons.
nikoshell May 15, 2025
3225c72
Clean up: Port Map component to Astro.
nikoshell May 15, 2025
97b3405
Clean up: Port Note and upgrade styles.
nikoshell May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/map/map.tsx → src/components/Map.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
export const Map = () => (
<Fragment is:raw>
<iframe
src="https://www.google.com/maps/embed?pb=!1m14!1m8!1m3!1d10245.064741908278!2d14.4290206!3d50.0625764!3m2!1i1024!2i768!4f13.1!3m3!1m2!1s0x0%3A0x4d26855708eb61f7!2sPrague%20Congress%20Centre!5e0!3m2!1sen!2suk!4v1676555813425!5m2!1sen!2suk"
title="Map"
className="w-full aspect-video max-w-[800px] border-4 border-white rounded-lg shadow-lg"
allowFullScreen={true}
class="w-full aspect-video max-w-[800px] border-4 border-white rounded-lg shadow-lg"
allowFullScreen="true"
loading="lazy"
referrerPolicy="no-referrer-when-downgrade"
></iframe>
);
</Fragment>
Comment on lines +1 to +10
Copy link
Contributor

@clytaemnestra clytaemnestra May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I updated this in another PR: https://github.com/EuroPython/website/pull/1227/files#diff-d7d44fd3cc527b8dbcaa8b661a0eb769d94080a4ae4fccc535320ffdc9fa5fefR1

We need to have the component map generic and be able to pass coordinates from google maps, so it's reusable at multiple places

27 changes: 0 additions & 27 deletions src/components/link/link.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/map/index.tsx
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/pages/[...slug].astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { type CollectionEntry, getCollection } from "astro:content";
import Layout from "@layouts/MarkdownLayout.astro";

import Separator from "@ui/Separator.astro";
import { Map } from "@components/map";
import Map from "@components/Map.astro";
import YouTube from "@ui/YouTube.astro";
import HighlightCard from "@components/highlight-list/highlight-card.astro";
import HighlightItem from "@components/highlight-list/highlight-item.astro";
Expand Down