Navbar scrolling improvement. #1243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
Contributor
|
could you please summarize the changes? I checked both navbars and they behave the same, but based on the code it's accessibility improvements - is that correct or is there something more that I'm missing? but overall LGTM. |
Contributor
Author
This PR was prepared to solve this issue #1219. |
clytaemnestra
approved these changes
May 23, 2025
Contributor
clytaemnestra
left a comment
clytaemnestra
left a comment
There was a problem hiding this comment.
Alright. LGTM. @deutranium could you please test it out?
Member
|
hey hey! the issue (mentioned in #1219 ) still remains :// |
Contributor
Author
|
Working solution in PR #1312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.