Accessibility information #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Preview available
|
hugovk
reviewed
Jun 6, 2025
A lot of typos, enhanced wording. ... Co-authored-by: Hugo van Kemenade <[email protected]>
cybit
commented
Jun 6, 2025
Fixed link.
Contributor
Author
|
@hugovk Thank you for finding all the typos and little errors. I feel bad that I didn't catch them earlier. |
hypha
reviewed
Jun 6, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Some small suggestions. I think some of them might overlap with Hugo's comments which now are outdated as I was a very slower reviewer.
hypha
reviewed
Jun 6, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Now also following up with reviews for the FAQ and links files 😅
First pass with easily acceptable suggestions Co-authored-by: hypha <[email protected]>
for more information, see https://pre-commit.ci
hugovk
approved these changes
Jun 9, 2025
hypha
reviewed
Jun 9, 2025
thepetk
reviewed
Jun 9, 2025
Contributor
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
Great work! Just added some thoughts I had during my review!
Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: hypha <[email protected]>
hypha
approved these changes
Jun 10, 2025
Contributor
hypha
left a comment
hypha
left a comment
There was a problem hiding this comment.
Just one wee tidy-up suggestion of the new paragraph added. Everything else looks good to me. Thank you, Cyril for the work and the patience addressing my messy comments! <3
Co-authored-by: hypha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic information about accessibility.
It would be nice if we could fill this out a bit more.