Add support for numeric keys

Author: EvanBacon

src/json/__tests__/fixtures/01-float.pbxproj

@@ -3,7 +3,7 @@
 	archiveVersion = 1;
 	objectVersion = 54;
 	objects = {
-		83CBB9F71A601CBA00E9B192 = {
+		123456789123456789012345 = {
 			isa = PBXProject;
 			one = 0.0;
 			two = 1.1;
@@ -13,5 +13,5 @@
 			six = 01;
 		};
 	};
-	rootObject = 83CBB9F71A601CBA00E9B192;
+	rootObject = 123456789123456789012345;
 }

src/json/__tests__/json.test.ts

@@ -10,6 +10,23 @@ import {
 } from "./compare-utils";
 
 describe(parse, () => {
+  it("should keep numeric object keys as strings", () => {
+    const input = `{ 123 = abc; 456 = { 789 = def; }; }`;
+    const result = parse(input) as any;
+
+    expect(result).toEqual({
+      "123": "abc",
+      "456": {
+        "789": "def"
+      }
+    });
+
+    // Verify keys are strings, not numbers
+    expect(typeof Object.keys(result)[0]).toBe("string");
+    expect(typeof Object.keys(result)[1]).toBe("string");
+    expect(typeof Object.keys(result["456"])[0]).toBe("string");
+  });
+
   const fixtures = [
     "01-float.pbxproj",
     "006-spm.pbxproj",

src/json/visitor/JsonVisitor.ts

@@ -37,11 +37,25 @@ export class JsonVisitor extends BaseVisitor {
   }
 
   objectItem(ctx: any) {
+    // Object keys must always be strings, even if they're numeric
+    const key = this.visitIdentifierAsString(ctx.identifier);
     return {
-      [this.visit(ctx.identifier)]: this.visit(ctx.value),
+      [key]: this.visit(ctx.value),
     };
   }
 
+  /** Visit an identifier and ensure the result is always a string (used for object keys) */
+  visitIdentifierAsString(identifierCtx: any) {
+    // Extract the actual context - identifierCtx is an array with a single item containing children
+    const ctx = identifierCtx[0]?.children || identifierCtx;
+    if (ctx.QuotedString) {
+      return ctx.QuotedString[0].payload ?? ctx.QuotedString[0].image;
+    } else if (ctx.StringLiteral) {
+      return ctx.StringLiteral[0].payload ?? ctx.StringLiteral[0].image;
+    }
+    throw new Error("unhandled identifier: " + JSON.stringify(identifierCtx));
+  }
+
   identifier(ctx: any) {
     if (ctx.QuotedString) {
       return ctx.QuotedString[0].payload ?? ctx.QuotedString[0].image;
@@ -71,7 +85,19 @@ function parseType(literal: string): number | string {
   if (/^0\d+$/.test(literal)) {
     return literal;
   }
-  
+
+  // Handle integers - check if they're safe to convert
+  if (/^\d+$/.test(literal)) {
+    const num = parseInt(literal, 10);
+    // Only convert to number if it's within JavaScript's safe integer range
+    // Xcode UUIDs are often 24 characters which exceed MAX_SAFE_INTEGER
+    if (!isNaN(num) && Number.isSafeInteger(num)) {
+      return num;
+    }
+    // Preserve as string if too large
+    return literal;
+  }
+
   // Handle decimal numbers but preserve trailing zeros
   if (/^[+-]?([0-9]+\.?[0-9]*|\.[0-9]+)$/.test(literal)) {
     if (/0$/.test(literal)) {
@@ -80,12 +106,6 @@ function parseType(literal: string): number | string {
     const num = parseFloat(literal);
     if (!isNaN(num)) return num;
   }
-  
-  // Handle integers
-  if (/^\d+$/.test(literal)) {
-    const num = parseInt(literal, 10);
-    if (!isNaN(num)) return num;
-  }
-  
+
   return literal;
 }