improve remove method

Author: EvandroLG

array.lua

@@ -429,7 +429,7 @@ array = {
   -- @value {*}
   -- @start_or_finish {number}
   -- @finish {number}
-  -- @returns table
+  -- @returns {table}
   fill = function(value, start_or_finish, finish)
     local output = {}
     local item = value
@@ -448,6 +448,11 @@ array = {
     return output
   end,
 
+  -- Remove all elements from table that @callback returns thruthy for
+  -- and returns a new table with the removed items
+  -- @obj {table}
+  -- @callback {function}
+  -- @returns {@table}
   remove = function(obj, callback)
     local output = {}
     local copy = array.deep_copy(obj)
@@ -457,6 +462,8 @@ array = {
 
       if callback(value, i) then
         table.insert(output, value)
+        local index = array.index_of(obj, value)
+        table.remove(obj, index)
       end
     end
 

test.lua

@@ -315,12 +315,16 @@ test('fill should create a table using the value passed by argument from start t
   a.equal(result[4], value)
 end)
 
-test('remove should return a new table with all elements from table that callback returns truthy for', function(a)
+test('remove should delete items that callback returns thruthy and should return a new table with the removed items', function(a)
   local list = { 1, 2, 3, 4 }
   local result = array.remove(list, function(value)
     return math.fmod(value, 2) == 0
   end)
 
+  a.equal(#list, 2)
+  a.equal(list[1], 1)
+  a.equal(list[2], 3)
+
   a.equal(#result, 2)
   a.equal(result[1], 2)
   a.equal(result[2], 4)