Skip to content

Commit df89cc6

Browse files
GernotMaierCopilot
andauthored
Remove unused n_tel parameter (#52)
* Remove unused n_tel parameter * Update src/eventdisplay_ml/config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 27dbfc4 commit df89cc6

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

src/eventdisplay_ml/config.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,17 @@ def configure_training(analysis_type):
3434
parser.add_argument(
3535
"--model_prefix",
3636
required=True,
37-
help=("Path to directory for writing XGBoost models (without n_tel / energy bin suffix)."),
37+
help=(
38+
"Path prefix for writing XGBoost models (without energy bin suffix; "
39+
"suffix is added automatically)."
40+
),
3841
)
3942
parser.add_argument(
4043
"--hyperparameter_config",
4144
help="Path to JSON file with hyperparameter configuration.",
4245
default=None,
4346
type=str,
4447
)
45-
parser.add_argument("--n_tel", type=int, help="Telescope multiplicity (2, 3, or 4).")
4648
parser.add_argument(
4749
"--train_test_fraction",
4850
type=float,
@@ -111,7 +113,6 @@ def configure_training(analysis_type):
111113

112114
_logger.info(f"--- XGBoost {analysis_type} training ---")
113115
_logger.info(f"Observatory: {model_configs.get('observatory')}")
114-
_logger.info(f"Telescope multiplicity: {model_configs.get('n_tel')}")
115116
_logger.info(f"Model output prefix: {model_configs.get('model_prefix')}")
116117
_logger.info(f"Train vs test fraction: {model_configs['train_test_fraction']}")
117118
_logger.info(f"Random state: {model_configs['random_state']}")
@@ -131,15 +132,14 @@ def configure_training(analysis_type):
131132

132133
if analysis_type == "stereo_analysis":
133134
model_configs["pre_cuts"] = pre_cuts_regression(
134-
model_configs.get("n_tel"), min_images=model_configs.get("min_images", 2)
135+
min_images=model_configs.get("min_images", 2)
135136
)
136137
elif analysis_type == "classification":
137138
_logger.info(f"Energy bin {model_configs['energy_bin_number']}")
138139
model_parameters = utils.load_model_parameters(
139140
model_configs["model_parameters"], model_configs["energy_bin_number"]
140141
)
141142
model_configs["pre_cuts"] = pre_cuts_classification(
142-
model_configs.get("n_tel"),
143143
e_min=np.power(10.0, model_parameters.get("energy_bins_log10_tev", []).get("E_min")),
144144
e_max=np.power(10.0, model_parameters.get("energy_bins_log10_tev", []).get("E_max")),
145145
)
@@ -165,7 +165,7 @@ def configure_apply(analysis_type):
165165
"--model_prefix",
166166
required=True,
167167
metavar="MODEL_PREFIX",
168-
help=("Path to directory containing XGBoost models (without n_tel / energy bin suffix)."),
168+
help=("Path to directory containing XGBoost models (without energy bin suffix)."),
169169
)
170170
parser.add_argument(
171171
"--model_name",

src/eventdisplay_ml/hyper_parameters.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -88,14 +88,12 @@ def _load_hyper_parameters_from_file(config_file):
8888
return hyperparameters
8989

9090

91-
def pre_cuts_regression(n_tel, min_images=2):
91+
def pre_cuts_regression(min_images=2):
9292
"""
9393
Get pre-cuts for regression analysis.
9494
9595
Parameters
9696
----------
97-
n_tel : int or None
98-
Number of telescopes (not currently used).
9997
min_images : int
10098
Minimum number of images (DispNImages) for quality cut (default: 2).
10199
@@ -112,7 +110,7 @@ def pre_cuts_regression(n_tel, min_images=2):
112110
return event_cut if event_cut else None
113111

114112

115-
def pre_cuts_classification(n_tel, e_min, e_max):
113+
def pre_cuts_classification(e_min, e_max):
116114
"""Get pre-cuts for classification analysis (no multiplicity filter)."""
117115
event_cut = f"(Erec >= {e_min}) & (Erec < {e_max})"
118116
event_cut += " & " + " & ".join(f"({c})" for c in PRE_CUTS_CLASSIFICATION)

0 commit comments

Comments
 (0)