v2 fix #1409: работа ЧтенияДанных из ДвоичныхДанных большого размера

[Mr-Rm]

Ранее падало на

ДвоичныеДанные = Новый ДвоичныеДанные("MoreThan50MiB.file"); 
ЧтениеДанных = Новый ЧтениеДанных(ДвоичныеДанные);

Внешнее исключение (System.IO.IOException): The process cannot access the file 'tmpE038.tmp' because it is being used by another process.

Причину см.: dotnet/runtime#91484 (comment)

Summary by CodeRabbit

• Refactor
  • Adjusted file stream handling to support concurrent deletion during read operations.
  • Streamlined data reading logic with a more concise control flow for improved consistency.

[coderabbitai]

Walkthrough

This pull request modifies two components in the OneScript Standard Library. In the BackingTemporaryFile class, the OpenReadStream method now opens file streams with FileShare.Delete in addition to allowing reading. In the DataReader class, the constructor logic is refactored by promoting the stream variable to a broader scope and replacing nested if-else blocks with a switch expression for selecting the appropriate stream based on the provided data source.

Changes

File(s)	Change Summary
src/OneScript.StandardLibrary/Binary/BackingTemporaryFile.cs	Updated OpenReadStream to open file streams with FileShare.Delete instead of FileShare.Read, permitting file deletion while the stream is open.
src/OneScript.StandardLibrary/Binary/DataReader.cs	Refactored the constructor by promoting the stream variable to a broader scope and replacing nested conditional logic with a switch expression for stream determination.

Sequence Diagram(s)

sequenceDiagram
    participant C as Caller
    participant B as BackingTemporaryFile
    participant FS as File System
    C->>B: Call OpenReadStream()
    B->>FS: Open file stream with FileShare.Delete
    FS-->>B: Return file stream
    B-->>C: Return stream

Loading

sequenceDiagram
    participant Client as Caller
    participant D as DataReader
    Client->>D: Invoke Constructor(dataSource, ...)
    D->>D: Evaluate dataSource with switch expression
    D-->>Client: Return DataReader instance with assigned stream

Loading

Poem

I'm a rabbit with a joyful grin,
Hopping through bytes as changes begin!
Streams now dance with deletion flair,
Switch expressions smooth up the code with care.
Leaping into new logic, I cheer with delight,
Code sprouts like clover in the spring light!
🐇💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/OneScript.StandardLibrary/Binary/DataReader.cs (1)

76-76: Add FileShare.Delete to FileStream for consistency.

For consistency with the changes in BackingTemporaryFile, consider adding FileShare.Delete to prevent potential file access conflicts.

-                stream = new FileStream(dataSource.AsString(), FileMode.Open, FileAccess.Read, FileShare.Read);
+                stream = new FileStream(dataSource.AsString(), FileMode.Open, FileAccess.Read, FileShare.Read | FileShare.Delete);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a3239d and ca5f35b.

📒 Files selected for processing (2)

• src/OneScript.StandardLibrary/Binary/BackingTemporaryFile.cs (1 hunks)
• src/OneScript.StandardLibrary/Binary/DataReader.cs (1 hunks)

🔇 Additional comments (2)

src/OneScript.StandardLibrary/Binary/BackingTemporaryFile.cs (1)

59-59: LGTM! This change resolves the file access conflict.

The addition of FileShare.Delete to the file sharing options allows the temporary file to be deleted even while it's being read, preventing the "file in use" IOException mentioned in the PR description.

src/OneScript.StandardLibrary/Binary/DataReader.cs (1)

73-89: LGTM! Code refactoring improves readability.

The switch expression provides a more concise and maintainable way to handle different data source types, while the broader scope for the stream variable reduces code duplication.