refactor(eslint): change unused vars rule to error and update error handling in services

DavidsonGomes · DavidsonGomes · commit 5e08628d8934 · 2025-09-18T14:59:33.000-03:00
- Update ESLint configuration to set `@typescript-eslint/no-unused-vars` from 'warn' to 'error' for stricter linting.
- Refactor error handling in various services to omit error variable in catch blocks for cleaner code.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -26,7 +26,7 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-empty-function': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
-    '@typescript-eslint/no-unused-vars': 'warn',
+    '@typescript-eslint/no-unused-vars': 'error',
     'import/first': 'error',
     'import/no-duplicates': 'error',
     'simple-import-sort/imports': 'error',
diff --git a/src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts b/src/api/integrations/channel/whatsapp/whatsapp.baileys.service.ts
@@ -445,7 +445,7 @@ export class BaileysStartupService extends ChannelStartupService {
       try {
         const profilePic = await this.profilePicture(this.instance.wuid);
         this.instance.profilePictureUrl = profilePic.profilePictureUrl;
-      } catch (error) {
+      } catch {
         this.instance.profilePictureUrl = null;
       }
       const formattedWuid = this.instance.wuid.split('@')[0].padEnd(30, ' ');
@@ -524,7 +524,7 @@ export class BaileysStartupService extends ChannelStartupService {
       }
 
       return webMessageInfo[0].message;
-    } catch (error) {
+    } catch {
       return { conversation: '' };
     }
   }
@@ -597,7 +597,7 @@ export class BaileysStartupService extends ChannelStartupService {
           const rand = Math.floor(Math.random() * Math.floor(proxyUrls.length));
           const proxyUrl = 'http://' + proxyUrls[rand];
           options = { agent: makeProxyAgent(proxyUrl), fetchAgent: makeProxyAgent(proxyUrl) };
-        } catch (error) {
+        } catch {
           this.localProxy.enabled = false;
         }
       } else {
@@ -1189,7 +1189,7 @@ export class BaileysStartupService extends ChannelStartupService {
                   where: { id: existingChat.id },
                   data: { name: received.pushName },
                 });
-              } catch (error) {
+              } catch {
                 console.log(`Chat insert record ignored: ${received.key.remoteJid} - ${this.instanceId}`);
               }
             }
@@ -1564,7 +1564,7 @@ export class BaileysStartupService extends ChannelStartupService {
             if (this.configService.get<Database>('DATABASE').SAVE_DATA.CHATS) {
               try {
                 await this.prismaRepository.chat.update({ where: { id: existingChat.id }, data: chatToInsert });
-              } catch (error) {
+              } catch {
                 console.log(`Chat insert record ignored: ${chatToInsert.remoteJid} - ${chatToInsert.instanceId}`);
               }
             }
@@ -1832,7 +1832,7 @@ export class BaileysStartupService extends ChannelStartupService {
       const profilePictureUrl = await this.client.profilePictureUrl(jid, 'image');
 
       return { wuid: jid, profilePictureUrl };
-    } catch (error) {
+    } catch {
       return { wuid: jid, profilePictureUrl: null };
     }
   }
@@ -1842,7 +1842,7 @@ export class BaileysStartupService extends ChannelStartupService {
 
     try {
       return { wuid: jid, status: (await this.client.fetchStatus(jid))[0]?.status };
-    } catch (error) {
+    } catch {
       return { wuid: jid, status: null };
     }
   }
@@ -1891,7 +1891,7 @@ export class BaileysStartupService extends ChannelStartupService {
           website: business?.website?.shift(),
         };
       }
-    } catch (error) {
+    } catch {
       return { wuid: jid, name: null, picture: null, status: null, os: null, isBusiness: false };
     }
   }
@@ -2131,7 +2131,7 @@ export class BaileysStartupService extends ChannelStartupService {
           if (!cache.REDIS.ENABLED && !cache.LOCAL.ENABLED) group = await this.findGroup({ groupJid: sender }, 'inner');
           else group = await this.getGroupMetadataCache(sender);
           // group = await this.findGroup({ groupJid: sender }, 'inner');
-        } catch (error) {
+        } catch {
           throw new NotFoundException('Group not found');
         }
 
@@ -3640,7 +3640,7 @@ export class BaileysStartupService extends ChannelStartupService {
           {},
           { logger: P({ level: 'error' }) as any, reuploadRequest: this.client.updateMediaMessage },
         );
-      } catch (err) {
+      } catch {
         this.logger.error('Download Media failed, trying to retry in 5 seconds...');
         await new Promise((resolve) => setTimeout(resolve, 5000));
         const mediaType = Object.keys(msg.message).find((key) => key.endsWith('Message'));
@@ -4230,7 +4230,7 @@ export class BaileysStartupService extends ChannelStartupService {
   public async inviteInfo(id: GroupInvite) {
     try {
       return await this.client.groupGetInviteInfo(id.inviteCode);
-    } catch (error) {
+    } catch {
       throw new NotFoundException('No invite info', id.inviteCode);
     }
   }
@@ -4253,7 +4253,7 @@ export class BaileysStartupService extends ChannelStartupService {
       }
 
       return { send: true, inviteUrl };
-    } catch (error) {
+    } catch {
       throw new NotFoundException('No send invite');
     }
   }
@@ -4717,7 +4717,7 @@ export class BaileysStartupService extends ChannelStartupService {
         collectionsLength: collections?.length,
         collections: collections,
       };
-    } catch (error) {
+    } catch {
       return { wuid: jid, name: null, isBusiness: false };
     }
   }
diff --git a/src/api/integrations/chatbot/base-chatbot.service.ts b/src/api/integrations/chatbot/base-chatbot.service.ts
@@ -49,7 +49,7 @@ export abstract class BaseChatbotService<BotType = any, SettingsType = any> {
     try {
       JSON.parse(str);
       return true;
-    } catch (e) {
+    } catch {
       return false;
     }
   }
diff --git a/src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts b/src/api/integrations/chatbot/chatwoot/services/chatwoot.service.ts
@@ -130,7 +130,7 @@ export class ChatwootService {
   public async find(instance: InstanceDto): Promise<ChatwootDto> {
     try {
       return await this.waMonitor.waInstances[instance.instanceName].findChatwoot();
-    } catch (error) {
+    } catch {
       this.logger.error('chatwoot not found');
       return { enabled: null, url: '' };
     }
@@ -370,7 +370,7 @@ export class ChatwootService {
       });
 
       return contact;
-    } catch (error) {
+    } catch {
       return null;
     }
   }
@@ -407,7 +407,7 @@ export class ChatwootService {
       }
 
       return true;
-    } catch (error) {
+    } catch {
       return false;
     }
   }
@@ -2552,7 +2552,7 @@ export class ChatwootService {
       await chatwootImport.importHistoryMessages(instance, this, inbox, this.provider);
       const waInstance = this.waMonitor.waInstances[instance.instanceName];
       waInstance.clearCacheChatwoot();
-    } catch (error) {
+    } catch {
       return;
     }
   }
diff --git a/src/api/integrations/storage/s3/libs/minio.server.ts b/src/api/integrations/storage/s3/libs/minio.server.ts
@@ -33,7 +33,7 @@ const bucketExists = async () => {
     try {
       const list = await minioClient.listBuckets();
       return list.find((bucket) => bucket.name === bucketName);
-    } catch (error) {
+    } catch {
       return false;
     }
   }
diff --git a/src/api/services/proxy.service.ts b/src/api/services/proxy.service.ts
@@ -25,7 +25,7 @@ export class ProxyService {
       }
 
       return result;
-    } catch (error) {
+    } catch {
       return null;
     }
   }
diff --git a/src/api/services/settings.service.ts b/src/api/services/settings.service.ts
@@ -24,7 +24,7 @@ export class SettingsService {
       }
 
       return result;
-    } catch (error) {
+    } catch {
       return null;
     }
   }
diff --git a/src/utils/use-multi-file-auth-state-prisma.ts b/src/utils/use-multi-file-auth-state-prisma.ts
@@ -19,7 +19,7 @@ export async function keyExists(sessionId: string): Promise<any> {
   try {
     const key = await prismaRepository.session.findUnique({ where: { sessionId: sessionId } });
     return !!key;
-  } catch (error) {
+  } catch {
     return false;
   }
 }
@@ -38,7 +38,7 @@ export async function saveKey(sessionId: string, keyJson: any): Promise<any> {
       where: { sessionId: sessionId },
       data: { creds: JSON.stringify(keyJson) },
     });
-  } catch (error) {
+  } catch {
     return null;
   }
 }
@@ -49,7 +49,7 @@ export async function getAuthKey(sessionId: string): Promise<any> {
     if (!register) return null;
     const auth = await prismaRepository.session.findUnique({ where: { sessionId: sessionId } });
     return JSON.parse(auth?.creds);
-  } catch (error) {
+  } catch {
     return null;
   }
 }
@@ -59,7 +59,7 @@ async function deleteAuthKey(sessionId: string): Promise<any> {
     const register = await keyExists(sessionId);
     if (!register) return;
     await prismaRepository.session.delete({ where: { sessionId: sessionId } });
-  } catch (error) {
+  } catch {
     return;
   }
 }
@@ -68,7 +68,7 @@ async function fileExists(file: string): Promise<any> {
   try {
     const stat = await fs.stat(file);
     if (stat.isFile()) return true;
-  } catch (error) {
+  } catch {
     return;
   }
 }
@@ -119,7 +119,7 @@ export default async function useMultiFileAuthStatePrisma(
 
       const parsedData = JSON.parse(rawData, BufferJSON.reviver);
       return parsedData;
-    } catch (error) {
+    } catch {
       return null;
     }
   }
@@ -137,7 +137,7 @@ export default async function useMultiFileAuthStatePrisma(
       } else {
         await deleteAuthKey(sessionId);
       }
-    } catch (error) {
+    } catch {
       return;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`445`	`445`	`try {`
`446`	`446`	`const profilePic = await this.profilePicture(this.instance.wuid);`
`447`	`447`	`this.instance.profilePictureUrl = profilePic.profilePictureUrl;`
`448`		`- } catch (error) {`
	`448`	`+ } catch {`
`449`	`449`	`this.instance.profilePictureUrl = null;`
`450`	`450`	`}`
`451`	`451`	`const formattedWuid = this.instance.wuid.split('@')[0].padEnd(30, ' ');`
`@@ -524,7 +524,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`524`	`524`	`}`
`525`	`525`
`526`	`526`	`return webMessageInfo[0].message;`
`527`		`- } catch (error) {`
	`527`	`+ } catch {`
`528`	`528`	`return { conversation: '' };`
`529`	`529`	`}`
`530`	`530`	`}`
`@@ -597,7 +597,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`597`	`597`	`const rand = Math.floor(Math.random() * Math.floor(proxyUrls.length));`
`598`	`598`	`const proxyUrl = 'http://' + proxyUrls[rand];`
`599`	`599`	`options = { agent: makeProxyAgent(proxyUrl), fetchAgent: makeProxyAgent(proxyUrl) };`
`600`		`- } catch (error) {`
	`600`	`+ } catch {`
`601`	`601`	`this.localProxy.enabled = false;`
`602`	`602`	`}`
`603`	`603`	`} else {`
`@@ -1189,7 +1189,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`1189`	`1189`	`where: { id: existingChat.id },`
`1190`	`1190`	`data: { name: received.pushName },`
`1191`	`1191`	`});`
`1192`		`- } catch (error) {`
	`1192`	`+ } catch {`
`1193`	`1193`	console.log(`Chat insert record ignored: ${received.key.remoteJid} - ${this.instanceId}`);
`1194`	`1194`	`}`
`1195`	`1195`	`}`
`@@ -1564,7 +1564,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`1564`	`1564`	`if (this.configService.get<Database>('DATABASE').SAVE_DATA.CHATS) {`
`1565`	`1565`	`try {`
`1566`	`1566`	`await this.prismaRepository.chat.update({ where: { id: existingChat.id }, data: chatToInsert });`
`1567`		`- } catch (error) {`
	`1567`	`+ } catch {`
`1568`	`1568`	console.log(`Chat insert record ignored: ${chatToInsert.remoteJid} - ${chatToInsert.instanceId}`);
`1569`	`1569`	`}`
`1570`	`1570`	`}`
`@@ -1832,7 +1832,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`1832`	`1832`	`const profilePictureUrl = await this.client.profilePictureUrl(jid, 'image');`
`1833`	`1833`
`1834`	`1834`	`return { wuid: jid, profilePictureUrl };`
`1835`		`- } catch (error) {`
	`1835`	`+ } catch {`
`1836`	`1836`	`return { wuid: jid, profilePictureUrl: null };`
`1837`	`1837`	`}`
`1838`	`1838`	`}`
`@@ -1842,7 +1842,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`1842`	`1842`
`1843`	`1843`	`try {`
`1844`	`1844`	`return { wuid: jid, status: (await this.client.fetchStatus(jid))[0]?.status };`
`1845`		`- } catch (error) {`
	`1845`	`+ } catch {`
`1846`	`1846`	`return { wuid: jid, status: null };`
`1847`	`1847`	`}`
`1848`	`1848`	`}`
`@@ -1891,7 +1891,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`1891`	`1891`	`website: business?.website?.shift(),`
`1892`	`1892`	`};`
`1893`	`1893`	`}`
`1894`		`- } catch (error) {`
	`1894`	`+ } catch {`
`1895`	`1895`	`return { wuid: jid, name: null, picture: null, status: null, os: null, isBusiness: false };`
`1896`	`1896`	`}`
`1897`	`1897`	`}`
`@@ -2131,7 +2131,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`2131`	`2131`	`if (!cache.REDIS.ENABLED && !cache.LOCAL.ENABLED) group = await this.findGroup({ groupJid: sender }, 'inner');`
`2132`	`2132`	`else group = await this.getGroupMetadataCache(sender);`
`2133`	`2133`	`// group = await this.findGroup({ groupJid: sender }, 'inner');`
`2134`		`- } catch (error) {`
	`2134`	`+ } catch {`
`2135`	`2135`	`throw new NotFoundException('Group not found');`
`2136`	`2136`	`}`
`2137`	`2137`
`@@ -3640,7 +3640,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`3640`	`3640`	`{},`
`3641`	`3641`	`{ logger: P({ level: 'error' }) as any, reuploadRequest: this.client.updateMediaMessage },`
`3642`	`3642`	`);`
`3643`		`- } catch (err) {`
	`3643`	`+ } catch {`
`3644`	`3644`	`this.logger.error('Download Media failed, trying to retry in 5 seconds...');`
`3645`	`3645`	`await new Promise((resolve) => setTimeout(resolve, 5000));`
`3646`	`3646`	`const mediaType = Object.keys(msg.message).find((key) => key.endsWith('Message'));`
`@@ -4230,7 +4230,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`4230`	`4230`	`public async inviteInfo(id: GroupInvite) {`
`4231`	`4231`	`try {`
`4232`	`4232`	`return await this.client.groupGetInviteInfo(id.inviteCode);`
`4233`		`- } catch (error) {`
	`4233`	`+ } catch {`
`4234`	`4234`	`throw new NotFoundException('No invite info', id.inviteCode);`
`4235`	`4235`	`}`
`4236`	`4236`	`}`
`@@ -4253,7 +4253,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`4253`	`4253`	`}`
`4254`	`4254`
`4255`	`4255`	`return { send: true, inviteUrl };`
`4256`		`- } catch (error) {`
	`4256`	`+ } catch {`
`4257`	`4257`	`throw new NotFoundException('No send invite');`
`4258`	`4258`	`}`
`4259`	`4259`	`}`
`@@ -4717,7 +4717,7 @@ export class BaileysStartupService extends ChannelStartupService {`
`4717`	`4717`	`collectionsLength: collections?.length,`
`4718`	`4718`	`collections: collections,`
`4719`	`4719`	`};`
`4720`		`- } catch (error) {`
	`4720`	`+ } catch {`
`4721`	`4721`	`return { wuid: jid, name: null, isBusiness: false };`
`4722`	`4722`	`}`
`4723`	`4723`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export abstract class BaseChatbotService<BotType = any, SettingsType = any> {`
`49`	`49`	`try {`
`50`	`50`	`JSON.parse(str);`
`51`	`51`	`return true;`
`52`		`- } catch (e) {`
	`52`	`+ } catch {`
`53`	`53`	`return false;`
`54`	`54`	`}`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ export class ChatwootService {`
`130`	`130`	`public async find(instance: InstanceDto): Promise<ChatwootDto> {`
`131`	`131`	`try {`
`132`	`132`	`return await this.waMonitor.waInstances[instance.instanceName].findChatwoot();`
`133`		`- } catch (error) {`
	`133`	`+ } catch {`
`134`	`134`	`this.logger.error('chatwoot not found');`
`135`	`135`	`return { enabled: null, url: '' };`
`136`	`136`	`}`
`@@ -370,7 +370,7 @@ export class ChatwootService {`
`370`	`370`	`});`
`371`	`371`
`372`	`372`	`return contact;`
`373`		`- } catch (error) {`
	`373`	`+ } catch {`
`374`	`374`	`return null;`
`375`	`375`	`}`
`376`	`376`	`}`
`@@ -407,7 +407,7 @@ export class ChatwootService {`
`407`	`407`	`}`
`408`	`408`
`409`	`409`	`return true;`
`410`		`- } catch (error) {`
	`410`	`+ } catch {`
`411`	`411`	`return false;`
`412`	`412`	`}`
`413`	`413`	`}`
`@@ -2552,7 +2552,7 @@ export class ChatwootService {`
`2552`	`2552`	`await chatwootImport.importHistoryMessages(instance, this, inbox, this.provider);`
`2553`	`2553`	`const waInstance = this.waMonitor.waInstances[instance.instanceName];`
`2554`	`2554`	`waInstance.clearCacheChatwoot();`
`2555`		`- } catch (error) {`
	`2555`	`+ } catch {`
`2556`	`2556`	`return;`
`2557`	`2557`	`}`
`2558`	`2558`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ const bucketExists = async () => {`
`33`	`33`	`try {`
`34`	`34`	`const list = await minioClient.listBuckets();`
`35`	`35`	`return list.find((bucket) => bucket.name === bucketName);`
`36`		`- } catch (error) {`
	`36`	`+ } catch {`
`37`	`37`	`return false;`
`38`	`38`	`}`
`39`	`39`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export class ProxyService {`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`return result;`
`28`		`- } catch (error) {`
	`28`	`+ } catch {`
`29`	`29`	`return null;`
`30`	`30`	`}`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ export class SettingsService {`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`return result;`
`27`		`- } catch (error) {`
	`27`	`+ } catch {`
`28`	`28`	`return null;`
`29`	`29`	`}`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export async function keyExists(sessionId: string): Promise<any> {`
`19`	`19`	`try {`
`20`	`20`	`const key = await prismaRepository.session.findUnique({ where: { sessionId: sessionId } });`
`21`	`21`	`return !!key;`
`22`		`- } catch (error) {`
	`22`	`+ } catch {`
`23`	`23`	`return false;`
`24`	`24`	`}`
`25`	`25`	`}`
`@@ -38,7 +38,7 @@ export async function saveKey(sessionId: string, keyJson: any): Promise<any> {`
`38`	`38`	`where: { sessionId: sessionId },`
`39`	`39`	`data: { creds: JSON.stringify(keyJson) },`
`40`	`40`	`});`
`41`		`- } catch (error) {`
	`41`	`+ } catch {`
`42`	`42`	`return null;`
`43`	`43`	`}`
`44`	`44`	`}`
`@@ -49,7 +49,7 @@ export async function getAuthKey(sessionId: string): Promise<any> {`
`49`	`49`	`if (!register) return null;`
`50`	`50`	`const auth = await prismaRepository.session.findUnique({ where: { sessionId: sessionId } });`
`51`	`51`	`return JSON.parse(auth?.creds);`
`52`		`- } catch (error) {`
	`52`	`+ } catch {`
`53`	`53`	`return null;`
`54`	`54`	`}`
`55`	`55`	`}`
`@@ -59,7 +59,7 @@ async function deleteAuthKey(sessionId: string): Promise<any> {`
`59`	`59`	`const register = await keyExists(sessionId);`
`60`	`60`	`if (!register) return;`
`61`	`61`	`await prismaRepository.session.delete({ where: { sessionId: sessionId } });`
`62`		`- } catch (error) {`
	`62`	`+ } catch {`
`63`	`63`	`return;`
`64`	`64`	`}`
`65`	`65`	`}`
`@@ -68,7 +68,7 @@ async function fileExists(file: string): Promise<any> {`
`68`	`68`	`try {`
`69`	`69`	`const stat = await fs.stat(file);`
`70`	`70`	`if (stat.isFile()) return true;`
`71`		`- } catch (error) {`
	`71`	`+ } catch {`
`72`	`72`	`return;`
`73`	`73`	`}`
`74`	`74`	`}`
`@@ -119,7 +119,7 @@ export default async function useMultiFileAuthStatePrisma(`
`119`	`119`
`120`	`120`	`const parsedData = JSON.parse(rawData, BufferJSON.reviver);`
`121`	`121`	`return parsedData;`
`122`		`- } catch (error) {`
	`122`	`+ } catch {`
`123`	`123`	`return null;`
`124`	`124`	`}`
`125`	`125`	`}`
`@@ -137,7 +137,7 @@ export default async function useMultiFileAuthStatePrisma(`
`137`	`137`	`} else {`
`138`	`138`	`await deleteAuthKey(sessionId);`
`139`	`139`	`}`
`140`		`- } catch (error) {`
	`140`	`+ } catch {`
`141`	`141`	`return;`
`142`	`142`	`}`
`143`	`143`	`}`