Skip to content

Commit 49d2129

Browse files
committed
Fixed to support websocket communication
1 parent 88413fa commit 49d2129

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

controllers/kernel_controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ func (c *KernelController) KernelChannelsHandler(w http.ResponseWriter, r *http.
171171
headers := http.Header{}
172172
headers.Set("Authorization", "token "+gatewayToken)
173173

174+
c.Logger.Debug().Str("targetURL", targetURL).Interface("headers", headers).Msg("Attempting to dial kernel gateway")
174175
// Connect to the Jupyter Kernel Gateway
175176
kgConn, _, err := websocket.DefaultDialer.Dial(targetURL, headers)
176177
if err != nil {

pkg/middleware/log_middleware.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
package middleware
22

33
import (
4+
"bufio"
5+
"fmt"
6+
"net"
47
"net/http"
58
"time"
69

@@ -18,6 +21,14 @@ func (r *statusRecorder) WriteHeader(code int) {
1821
r.ResponseWriter.WriteHeader(code)
1922
}
2023

24+
func (r *statusRecorder) Hijack() (net.Conn, *bufio.ReadWriter, error) {
25+
h, ok := r.ResponseWriter.(http.Hijacker)
26+
if !ok {
27+
return nil, nil, fmt.Errorf("hijack not supported")
28+
}
29+
return h.Hijack()
30+
}
31+
2132
func RequestLogger(next http.Handler) http.Handler {
2233
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
2334

0 commit comments

Comments
 (0)