Address few issues in the code.

**What**

- Add JavaDoc to one of the classes to make it more clear what it does.
- Fix potential NPE.
- Use item factory to create prism reference value instead of direct
  constructor.

**Why**

The item factory is used to not rely on implementation details of the
prism objects (in a broad sense not the `PrismObject` directly).

**Task**: 11112

Author: and-za

model/model-impl/src/main/java/com/evolveum/midpoint/model/impl/correlation/ResourceCorrelationDefinitionProvider.java

@@ -7,18 +7,31 @@
 
 package com.evolveum.midpoint.model.impl.correlation;
 
+import java.util.Objects;
 import java.util.Optional;
 
 import com.evolveum.midpoint.model.api.correlation.CorrelationDefinitionProvider;
 import com.evolveum.midpoint.schema.processor.ResourceObjectTypeDefinition;
 import com.evolveum.midpoint.schema.processor.ResourceObjectTypeIdentification;
 import com.evolveum.midpoint.schema.util.CorrelatorsDefinitionUtil;
 import com.evolveum.midpoint.schema.util.Resource;
+import com.evolveum.midpoint.schema.util.ShadowUtil;
 import com.evolveum.midpoint.util.exception.ConfigurationException;
 import com.evolveum.midpoint.util.exception.ObjectNotFoundException;
 import com.evolveum.midpoint.util.exception.SchemaException;
 import com.evolveum.midpoint.xml.ns._public.common.common_3.*;
 
+/**
+ * Provides correlation definition for a specific resource object type.
+ *
+ * This implementation of {@link CorrelationDefinitionProvider} resolves the correlation definition
+ * by merging information from two sources:
+ *
+ * . The resource object type definition from the complete schema (including short - attribute bound - form).
+ * . The object synchronization configuration from the resource's synchronization settings
+ *
+ * @see CorrelationDefinitionProvider
+ */
 public class ResourceCorrelationDefinitionProvider implements CorrelationDefinitionProvider {
     private final ResourceType resource;
     private final ResourceObjectTypeIdentification objectTypeId;
@@ -46,8 +59,9 @@ public CorrelationDefinitionType get() throws SchemaException, ObjectNotFoundExc
     }
 
     private boolean matchKindAndIntent(ObjectSynchronizationType synchronizationType) {
-        return this.objectTypeId.getKind().equals(synchronizationType.getKind())
-                && this.objectTypeId.getIntent().equals(synchronizationType.getIntent());
+        return Objects.equals(this.objectTypeId.getKind(), ShadowUtil.resolveDefault(synchronizationType.getKind()))
+                && Objects.equals(this.objectTypeId.getIntent(),
+                        ShadowUtil.resolveDefault(synchronizationType.getIntent()));
     }
 
 }

model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/mappings/ShadowWithOwner.java

@@ -1,8 +1,7 @@
 /*
- * Copyright (c) 2025 Evolveum and contributors
- *
- * Licenced under the EUPL-1.2 or later.
+ * Copyright (c) 2026 Evolveum and contributors
  *
+ * Licensed under the EUPL-1.2 or later.
  *
  */
 

model/smart-impl/src/test/java/com/evolveum/midpoint/smart/impl/TestMappingsSuggestionOperation.java

@@ -4,7 +4,7 @@
 import com.evolveum.midpoint.model.test.CommonInitialObjects;
 import com.evolveum.midpoint.model.test.smart.MockServiceClientImpl;
 import com.evolveum.midpoint.prism.PrismContext;
-import com.evolveum.midpoint.prism.impl.PrismReferenceValueImpl;
+import com.evolveum.midpoint.prism.PrismReferenceValue;
 import com.evolveum.midpoint.prism.path.ItemPath;
 import com.evolveum.midpoint.repo.common.expression.ExpressionFactory;
 import com.evolveum.midpoint.schema.processor.ResourceObjectTypeIdentification;
@@ -116,10 +116,12 @@ private void correlateAccount(TestObject<UserType> user, Task task, OperationRes
                 .withDefaultAccountType()
                 .withNameValue(user.getNameOrig())
                 .build().findRequired(task, result);
+        final PrismReferenceValue userReference = PrismContext.get().itemFactory().createReferenceValue(user.oid,
+                UserType.COMPLEX_TYPE);
         executeChanges(
                 PrismContext.get().deltaFor(ShadowType.class)
                         .item(ShadowType.F_CORRELATION, ShadowCorrelationStateType.F_RESULTING_OWNER)
-                        .add(new PrismReferenceValueImpl(user.oid, UserType.COMPLEX_TYPE))
+                        .add(userReference)
                         .asObjectDelta(shadow.getOid()),
                 null, task, result);
     }