Smart Integration: Fix wellknownschemas group name mapping suggestions

- Use dynamic resource name prefix instead of hardcoded 'ldap:' or 'ad:'
- Fix bug: use 'input' variable instead of attribute name in script
- Suggest both as-is and prefixed mappings (both STRONG strength)
- Applies to GroupOfNamesLdapMappingProvider and GroupActiveDirectoryMappingProvider

The prefixed mapping now generates: resource.name + '-' + input
Example: "MyLDAP-administrators" instead of "ldap:administrators"

Author: Michal Zelencik

model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ad/GroupActiveDirectoryMappingProvider.java

@@ -46,11 +46,12 @@ public Map<ItemPath, ItemPath> suggestSchemaMatches() {
     public List<SystemMappingSuggestion> suggestInboundMappings() {
         List<SystemMappingSuggestion> mappings = new ArrayList<>();
         mappings.add(SystemMappingSuggestion.createAsIsSuggestion("sAMAccountName", AbstractRoleType.F_IDENTIFIER));
+        mappings.add(SystemMappingSuggestion.createAsIsSuggestion("sAMAccountName", RoleType.F_NAME, MappingStrengthType.STRONG));
         mappings.add(SystemMappingSuggestion.createScriptSuggestion(
                 "sAMAccountName",
                 RoleType.F_NAME,
-                "'ad:' + sAMAccountName",
-                "Inbound: group-sync-methodology name with prefix (ad:<sAMAccountName>)",
+                "resource.name + '-' + input",
+                "Inbound: group name with resource prefix (<resource>-<sAMAccountName>)",
                 MappingStrengthType.STRONG));
         return mappings;
     }

model/smart-impl/src/main/java/com/evolveum/midpoint/smart/impl/wellknownschemas/ldap/GroupOfNamesLdapMappingProvider.java

@@ -46,11 +46,12 @@ public Map<ItemPath, ItemPath> suggestSchemaMatches() {
     public List<SystemMappingSuggestion> suggestInboundMappings() {
         List<SystemMappingSuggestion> mappings = new ArrayList<>();
         mappings.add(SystemMappingSuggestion.createAsIsSuggestion("cn", AbstractRoleType.F_IDENTIFIER));
+        mappings.add(SystemMappingSuggestion.createAsIsSuggestion("cn", RoleType.F_NAME, MappingStrengthType.STRONG));
         mappings.add(SystemMappingSuggestion.createScriptSuggestion(
                 "cn",
                 RoleType.F_NAME,
-                "'ldap:' + cn",
-                "Inbound: group-sync-methodology name with prefix (ldap:<cn>)",
+                "resource.name + '-' + input",
+                "Inbound: group name with resource prefix (<resource>-<cn>)",
                 MappingStrengthType.STRONG));
         return mappings;
     }