Added ConvertFrom-HtmlTable #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey! I made another commit, I wasn't clear on everything you mentioned over Twitter DMs, so let me know what you think when you have some more time. |
That's what I meant for changes ;-) 1. Skip instead of SkipIndex to support 5.1 2. Moved Output to proper place 3. Added [ordered] to hash to keep order of columns. For small tables not a problem, for larger ones columns would be out of place.
Made it so it displays examples properly.
Member
|
I've fixed a few things. Do you think it's ok now? :) |
Contributor
Author
|
Looks good to me! All tests I had run before still return as expected. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As well as an example. This is using the AngleSharp library which was already included in the module.