-Replaced 'File.ReadAllBytes' with 'ArrayPool<byte>.Shared'

-Optimized WAV header skipping (string comparisons to direct uint32 hex checks)

Author: MS-crew

EXILED/Exiled.API/Features/Audio/WavUtility.cs

@@ -8,6 +8,7 @@
 namespace Exiled.API.Features.Audio
 {
     using System;
+    using System.Buffers;
     using System.IO;
     using System.Runtime.InteropServices;
 
@@ -25,24 +26,36 @@ public static class WavUtility
         /// <returns>An array of floats representing the PCM data.</returns>
         public static float[] WavToPcm(string path)
         {
-            byte[] fileBytes = File.ReadAllBytes(path);
+            using FileStream fs = new(path, FileMode.Open, FileAccess.Read, FileShare.Read);
+            int length = (int)fs.Length;
 
-            using MemoryStream ms = new(fileBytes);
-            using BinaryReader br = new(ms);
+            byte[] rentedBuffer = ArrayPool<byte>.Shared.Rent(length);
 
-            SkipHeader(br);
+            try
+            {
+                int bytesRead = fs.Read(rentedBuffer, 0, length);
+
+                using MemoryStream ms = new(rentedBuffer, 0, bytesRead);
+                using BinaryReader br = new(ms);
 
-            int headerOffset = (int)ms.Position;
-            int dataLength = fileBytes.Length - headerOffset;
+                SkipHeader(br);
 
-            Span<byte> audioDataSpan = fileBytes.AsSpan(headerOffset, dataLength);
-            Span<short> samples = MemoryMarshal.Cast<byte, short>(audioDataSpan);
+                int headerOffset = (int)ms.Position;
+                int dataLength = bytesRead - headerOffset;
 
-            float[] pcm = new float[samples.Length];
-            for (int i = 0; i < samples.Length; i++)
-                pcm[i] = samples[i] / 32768f;
+                Span<byte> audioDataSpan = rentedBuffer.AsSpan(headerOffset, dataLength);
+                Span<short> samples = MemoryMarshal.Cast<byte, short>(audioDataSpan);
 
-            return pcm;
+                float[] pcm = new float[samples.Length];
+                for (int i = 0; i < samples.Length; i++)
+                    pcm[i] = samples[i] / 32768f;
+
+                return pcm;
+            }
+            finally
+            {
+                ArrayPool<byte>.Shared.Return(rentedBuffer);
+            }
         }
 
         /// <summary>
@@ -55,10 +68,11 @@ public static void SkipHeader(BinaryReader br)
 
             while (true)
             {
-                string chunk = new(br.ReadChars(4));
+                uint chunk = br.ReadUInt32();
                 int size = br.ReadInt32();
 
-                if (chunk == "fmt ")
+                // 'fmt ' chunk
+                if (chunk == 0x20746D66)
                 {
                     short format = br.ReadInt16();
                     short channels = br.ReadInt16();
@@ -72,14 +86,19 @@ public static void SkipHeader(BinaryReader br)
 
                     br.BaseStream.Position += size - 16;
                 }
-                else if (chunk == "data")
+
+                // 'data' chunk
+                else if (chunk == 0x61746164)
                 {
                     return;
                 }
                 else
                 {
                     br.BaseStream.Position += size;
                 }
+
+                if (br.BaseStream.Position >= br.BaseStream.Length)
+                    throw new InvalidDataException("WAV file does not contain a 'data' chunk. File might be corrupted or empty.");
             }
         }
     }