Fix home space schema application for favorites (commontoolsinc#2178)

* Fix home space schema application for favorites

* Fix type error

* Fix lint

Author: bfollington

packages/charm/src/manager.ts

@@ -157,7 +157,12 @@ export class CharmManager {
     );
     // Use the space DID as the cause - it's derived from the space name
     // and consistently available everywhere
-    this.spaceCell = this.runtime.getSpaceCell(this.space);
+    // For home space (where space DID = user identity DID), getHomeSpaceCell()
+    // uses homeSpaceCellSchema which includes favorites for proper sync/query behavior.
+    const isHomeSpace = this.space === this.runtime.userIdentityDID;
+    this.spaceCell = isHomeSpace
+      ? this.runtime.getHomeSpaceCell()
+      : this.runtime.getSpaceCell(this.space);
 
     const syncSpaceCell = Promise.resolve(this.spaceCell.sync());
 

packages/runner/src/index.ts

@@ -1,4 +1,4 @@
-export { Runtime, spaceCellSchema } from "./runtime.ts";
+export { homeSpaceCellSchema, Runtime, spaceCellSchema } from "./runtime.ts";
 export type {
   CharmMetadata,
   ConsoleHandler,

packages/runner/src/runtime.ts

@@ -95,7 +95,7 @@ export interface SpaceCellContents {
  * Home space contains user-specific data like favorites that persists across all spaces.
  * See docs/common/HOME_SPACE.md for more details.
  */
-export interface HomeSpaceCellContents {
+export interface HomeSpaceCellContents extends SpaceCellContents {
   favorites: Cell<{ cell: Cell<unknown>; tag: string }[]>;
 }
 
@@ -128,6 +128,17 @@ export const spaceCellSchema: JSONSchema = {
 export const homeSpaceCellSchema: JSONSchema = {
   type: "object",
   properties: {
+    // Include all space cell properties
+    allCharms: {
+      type: "array",
+      items: { not: true, asCell: true },
+    },
+    recentCharms: {
+      type: "array",
+      items: { not: true, asCell: true },
+    },
+    defaultPattern: { not: true, asCell: true },
+    // Plus home-space-specific properties
     favorites: {
       type: "array",
       items: {