Fix charm list view auto-dismiss (commontoolsinc#1945)

* Fix charm list view auto-dismiss

We regressed when reworking the 'active charm' concept. Clicking the 🔍 should show the charms list, clicking an item should navigate to it and dismiss the list. After our recent changes, we no longer automatically dismissed the list. This PR corrects that behaviour.

* Format pass

Author: bfollington

packages/shell/src/lib/app/state.ts

@@ -35,6 +35,9 @@ export function applyCommand(
   switch (command.type) {
     case "set-active-charm-id": {
       next.activeCharmId = command.charmId;
+      if (command.charmId) {
+        next.showShellCharmListView = false;
+      }
       break;
     }
     case "set-identity": {

packages/shell/test/app-state.test.ts

@@ -1,5 +1,6 @@
 import { describe, it } from "@std/testing/bdd";
 import {
+  applyCommand,
   AppState,
   AppStateSerialized,
   deserialize,
@@ -69,4 +70,18 @@ describe("AppState", () => {
     assert(state.spaceName === SPACE_NAME);
     assert(state.identity?.did() === identity.did(), "deserializes identity.");
   });
+
+  it("clears charm list view when activating a charm", () => {
+    const initial: AppState = {
+      apiUrl: new URL(API_URL),
+      showShellCharmListView: true,
+    };
+
+    const next = applyCommand(initial, {
+      type: "set-active-charm-id",
+      charmId: "example",
+    });
+
+    assert(next.showShellCharmListView === false);
+  });
 });