[pull] main from commontoolsinc:main #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal repro for strange conflict error. Turns it is because `NaN` gets mapped to `null` by JSON.stringify() and so the cause computed on the client and server diverged. Forcing JSON.parse(JSON.stringify()) before computing the cause fixed this. --------- Co-authored-by: Claude <[email protected]>
Fix derive() type inference for nested OpaqueRef arrays and sub-properties so callbacks receive plain values while preserving Cell<T>. Also widen boolean literal unions so boolean cells infer as boolean. - **Bug Fixes** - Refined OpaqueRef recursion: treat ArrayBuffer, ArrayBufferView, URL, and Date as-is; keep array/object recursion without intersecting with T. - Added derive overloads to widen OpaqueRef<true> | OpaqueRef<false> to boolean and to preserve Cell<T> at any OpaqueRef nesting level. - Introduced helper types to unwrap OpaqueRef layers and match Cell types; added regression tests for recipe outputs, nested arrays/intersections, boolean cells, direct Cell inputs, OpaqueRef<Cell<T>>, and destructured cases.
… cell(undefined) (#2033) * fix(runner): cell(0) or cell(false) or cell("") is no longer actually cell(undefined) * fix(runner): improved error messages for agents * fix(generated-patterns): remove .set() calls from lift/compute blocks and add error detection - Updated pattern-harness.ts to capture runtime errors via errorHandlers - Tests now fail if runtime errors occur, preventing silent failures - Removed unused lift with .set() call in assignment-grading-matrix - Removed problematic .set() calls from compute/lift blocks in: - bounded-counter - counter-conditional-branch - counter-conditional-child-instantiation - counter-mutable-tuple - counter-optional-fallback - counter-persistence-defaults - counter-persistence-initial-arguments - counter-rolling-average These .set() calls were throwing "Cannot create cell link: space is required" errors because lift/compute functions execute in a reactive context without proper space/frame for cell links. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )