[pull] main from commontoolsinc:main #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Align creation of sessions across the workspace as a precursor to identity signing.
This change introduces a new method `getArgumentCell()` that provides convenient access to the argument cell of an instantiated recipe. This is useful when you need to update the arguments of a running recipe instance and have the changes automatically propagate through the reactive system. Changes: - Add `getArgumentCell()` method to IResolvable interface in packages/api/index.ts - Supports both generic type parameter and JSONSchema validation - Returns Cell<T> | undefined (undefined if no source cell exists) - Implement `getArgumentCell()` in CellImpl (packages/runner/src/cell.ts) - Retrieves the source cell using existing getSourceCell() method - Kicks off sync to ensure latest data is available - Returns the "argument" key of the source cell with optional schema validation - Added to cellMethods set for proper proxy support - Add comprehensive test in packages/runner/test/cell.test.ts - Tests reactive behavior: instantiates a doubling recipe with an initial argument - Updates the argument via getArgumentCell() and verifies output changes - Tests multiple updates to ensure continued reactivity Use case: When working with recipe instances, you can now easily access and modify their arguments without manually navigating to the source cell's argument field. The method handles the complexity of retrieving the source cell and extracting the argument field while ensuring proper synchronization. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )