[pull] main from commontoolsinc:main #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test fixture pair for the pattern described in CT-1036: - Grouping items by a property into Record<K, V[]> - Deriving keys from the grouped object - Mapping over derived keys and accessing grouped[key] - Nested mapping over the accessed array This pattern runs successfully and transforms correctly with the current transformer. The JSX transformer properly wraps the property access (groupedByAisle[aisleName]) in a derive with both values as parameters, enabling reactive property access with derived keys. Related: CT-1036
…2071) **Problem:** Errors in DefaultPattern.create() were caught and logged but not re-thrown, causing silent failures. **Why this breaks mentions:** 1. linkDefaultPattern() fails (network glitch, race condition, etc.) 2. Error is swallowed → no indication to user 3. DefaultCharmList charm created successfully 4. But /defaultPattern link in space cell is missing 5. wish("#mentionable") resolves path: /defaultPattern/backlinksIndex/mentionable 6. Path resolution fails because /defaultPattern doesn't exist 7. Returns empty array instead of charm list 8. ct-code-editor receives empty mentionable list 9. [[ dropdown shows no completions **Symptom:** Type [[ in notes field → dropdown is empty (even though backlinksIndex has data) **Timeline:** - Oct 23 (947b471): linkDefaultPattern added - Nov 6 (or earlier): Spaces created with transient link failures - Today: Error swallowing discovered **Fix:** Re-throw errors to surface failures immediately. Future spaces will fail loudly if linking doesn't work, preventing silent corruption. **Workaround for affected spaces:** Delete packages/toolshed/cache/memory/*.sqlite and recreate spaces.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )