[pull] main from commontoolsinc:main #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: add fixture for Cell.get() in ifElse predicate bug Reproduces issue where transformer generates derive without schema for ifElse predicates, causing Cell parameters to be unwrapped when they should remain as Cells (with asCell: true in schema). Expected: derive with full schema preserving asCell: true Actual: derive without schema, unwrapping all values * change order of transformers
`pattern`, `recipe`, `lift` and `handler` now consistently produce factories that strip any Cell annotations, so that the type the developer declares matches the internal view while external callers can call with or without Cells. --- Also fixed TypeScript types in patterns by: 1. Adding Cell<> wrappers to input schema properties where UI components expect CellLike<T> values: - recipes: bgCounter, email-summarizer, gcal, gmail-importer, input, research-report, rss - patterns: chatbot, ct-checkbox-*, ct-list, ct-select, fetch-data, note 2. Removing extraneous asCell: true from simpleValue.tsx that was causing .length property errors 3. Making recipe input properties optional where they have Default<> values and adding fallback handling in recipe implementations 4. Fixing Cell import from type-only to regular import in note.tsx
…explicit types of stream (#2076)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )