[pull] main from commontoolsinc:main #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: Add charm linking guide Add comprehensive documentation for charm linking in CommonTools patterns, covering how to create source charms that expose data, consumer charms that receive linked data, and the CLI commands for deploying and linking charms. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * docs: Update charm linking guide to use port 8000 Update browser access URLs to use port 8000 instead of 5173, reflecting the upcoming convention change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Address PR review comments: pattern syntax and helper implementations - Change `recipe` to `pattern` throughout all examples - Add JSDoc comments above Input interfaces for charm titles - Add missing `parseData` lifted function implementation - Inline `percentile` helper inside `calculateStats` function - Update Quick Reference checklist to mention `pattern` and JSDoc 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Address remaining PR review comments from seefeldb - Remove third point about lift() for null-safe access from Key Rules - Remove fourth point about showing helpful UI when unlinked - Remove unused hasData and getAverage helpers from consumer example - Simplify consumer example to use linkedStats?.average directly - Add note about importing Stats type from source charm - Update Consumer Charm Checklist to be more concise 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> --------- Co-authored-by: Tony Espinoza <[email protected]> Co-authored-by: Claude <[email protected]>
…ts (#2156) * Add runtime.getSpaceCell, including a default schema * Refactor CharmManager to use runtime.getSpaceCell and SpaceCellContents
…2157) Cells can form cyclic graphs where a child references a parent. This caused the renderer to enter infinite loops. This change adds cycle detection in multiple places: - isVNode: Detects cycles when following [UI] chains - renderNode: Tracks visited nodes and renders 🔄 placeholder when cycle detected - renderChild: Tracks visited cells to detect cell graph cycles - updateChildren: Handles circular structures in JSON.stringify The same cell/node can still appear in different places in the UI (siblings), just not as parent-child. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]>
…rs (#2160) * Fix reactive dependencies not triggering when intermediate path appears When watching a path like ["a", "b", "c"], the algorithm would not trigger if an intermediate segment appeared. For example: - Before: { a: {} } - path a.b.c is "unreachable" (b doesn't exist) - After: { a: { b: { x: 1 } } } - b exists but c doesn't Both cases resolve to `undefined`, so no change was detected. But this is a structural change that should trigger subscribers, because the path became "more reachable". The fix distinguishes three cases: 1. Both paths reachable → compare actual values (original behavior) 2. Reachability changed → trigger (NEW) 3. Neither reachable but different traversal depth → trigger (NEW) This fixes issues where handlers watching paths through dynamically appearing keys (like internal.__#0.allCharms) would not fire on first load. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Format pass --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Ben Follington <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )