[pull] main from commontoolsinc:main #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1788) * store a selected charm in a cell (selectedCharm) and also maintain a list of charms (charmsList). show the selectedCharm in the UI, show a list of charms and allow user to change the value for selectedCharm which will update which charm we render * use Defaults instead of using cell() to create the selectedCharm and charmsList * use [ID] in the charmsList, each item is now of type CharmEntry * updated comment * added a lift for debugging the charms list, copied the id to local_id because i couldnt display [ID], removed [ID] from the JSON schema * wrap charm so we dont have pointer of pointer issue --------- Co-authored-by: Ellyse <[email protected]>
* When writing the link in ifElse, use setRaw * Added unit test
…result. (#1790) - If we revert a result cell (or get some other server driven change), our closure captured initializedUpTo state will be out of sync. If this means it points after the last element, re-initialize the missing elements.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )