[pull] main from commontoolsinc:main #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* change refs emission to be for all named non-container types (still do not auto-promote root)
* format
* doc with both short- and long-term strategies for finishing this implementation
* progress towards working implementation, still WIP
* update fixtures to no longer expect root types to always be promoted to named defs (only promote if referenced elsewhere)
* and finish updating js-runtime fixtures' expectations too
* don't include callables/function-like things in json schemas
* update README about skipping callables
* handle anonymous type cycles more properly by synthesizing a name for them AnonymousType_{counter}
* fix linting
* factor out structure for special-casing certain built-in types' schemas
* handle certain built-in types specially
* fix bug i just introduced
* fix built-in type handling
* improve handling of boolean schemas as per robin's PR comment
* fmt
* simplify a bit, removed uneccesasary lifts, use Default to create cell instead of calling cell() although i still create isInitialized from cell(), not sure how to turn that into a default via the json schema if thats possible. improved comments * use toSchema and ifElse to simplify code * set the sub charms name so its easier distinguish * undefined is not legal in JSONSchema, changed cellRef to default to null instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )