[pull] main from commontoolsinc:main #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(ralph): mount labs directory and use Playwright MCP for smoketests
- Remove git clone from Dockerfile, use bind mount instead
- Remove MCP setup from Dockerfile (done in run script after credentials copied)
- Add 5 second sleep for mount to settle
- Update run_smoketest.sh to mount labs dir and copy credentials
- Configure Playwright MCP after copying credentials to avoid overwrite
- Update SMOKETEST_PROMPT.md with working Playwright MCP instructions
- Change recipe-dev to pattern-dev, fix paths, update port to 8000
- Add space name requirement (ralph${RALPH_ID}) to avoid parallel conflicts
* Add log output to smoketest results directory
- Redirect Ralph smoketest output to /app/smoketest/${RALPH_ID}/ralph.log
- Update README to document log location and bind mount behavior
- Users can now tail -f the logs instead of using docker logs
- All smoketest outputs (logs, results, patterns) now in one directory
- Changed SMOKETEST_PROMPT.md to create patterns in /app/smoketest/${RALPH_ID}/ instead of /app/labs/packages/patterns/
* Remove sleep infinity from smoketest container
* Add container status polling to smoketest runner
- Updated SMOKETEST_PROMPT.md to instruct Ralph to name screenshots as ralph_${RALPH_ID}-<description>.png
- Updated run_smoketest.sh to automatically move screenshots to appropriate smoketest directories after completion
- Prevents screenshot conflicts between parallel Ralph instances
* Show results location and score summary after smoketests complete
s.
* Add RALPH_IDS variable and expand to support 8 tasks
* Fix cross-platform permission issues and add prerequisites
- Run containers as host user with -u $(id -u):$(id -g) to avoid UID mismatch
- Pre-create smoketest directories on host with correct ownership
- Added prerequisites to README:
- Docker installation link
- User must be in docker group (explains sudo credential issue)
- User must be logged into Claude CLI
- Removed mkdir from Dockerfile since host creates directories
* Mount credentials directly instead of copying to fix permission issues
- Mount ~/.claude.json and ~/.claude as read-only volumes to /tmp/home
- Set HOME=/tmp/home so container can write config files
- Ensure smoketest parent directory exists before creating subdirs
- Removed docker cp commands (no longer needed)
* Fix credential isolation: copy to /tmp/home instead of mounting
- Removed shared ~/.claude mounts that caused conflicts between containers
- Copy credentials into each container's /tmp/home (writable for host user)
- Each container gets its own isolated copy of Claude credentials
- Fixes read-only filesystem error and prevents cross-container conflicts
* Install Claude CLI and Codex globally for all users
* Add automatic docker pull to ensure latest image is used
- Document automatic image pull from Docker Hub
- Update manual run instructions to use host user and credential copying
- Replace outdated credential mount approach with current implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )