Merge pull request #15 from Exabyte-io/feat/SOF-6398

SOF-6398: add eslint preset and reformat

Author: unsigned6

.eslintrc.json

@@ -1,59 +1,4 @@
 {
-    "extends": ["airbnb", "prettier", "eslint:recommended"],
-    "settings": {
-        "import/resolver": {
-            "node": {
-                "paths": ["src"]
-            }
-        }
-    },
-    "parser": "@babel/eslint-parser",
-    "env": {
-        "browser": true,
-        "node": true,
-        "mocha": true
-    },
-    "plugins": ["prettier", "simple-import-sort", "jsdoc"],
-    "rules": {
-        "prettier/prettier": "error",
-        "comma-dangle": ["error", "always-multiline"],
-        "array-element-newline": ["error", "consistent"],
-        "no-plusplus": ["error", { "allowForLoopAfterthoughts":  true }],
-        "one-var": ["error", { "uninitialized": "always", "initialized": "never" }],
-        "brace-style": ["error", "1tbs", { "allowSingleLine":  true }],
-        "prefer-template": "off",
-        "camelcase": "off",
-        "max-len": "off",
-        "no-console": "off",
-        "no-unused-expressions": "warn",
-        "no-confusing-arrow": "off",
-        "no-underscore-dangle": "off",
-        "no-return-assign": "off",
-        "consistent-return": "off",
-        "arrow-body-style": "off",
-        "import/prefer-default-export": "off",
-        "import/no-named-as-default-member": "warn",
-        "no-param-reassign": ["warn", { "props": false }],
-        "max-classes-per-file": "warn",
-        "simple-import-sort/imports": [
-            "warn",
-            {
-                "groups": [
-                    // Side effect imports.
-                    ["^\\u0000"],
-                    // Packages.
-                    // Things that start with a letter (or digit or underscore), or `@` followed by a letter.
-                    ["^@?\\w"],
-                    // Absolute imports
-                    [
-                        "^(components|configs|constants|containers|domain|enhancers|hocs|libs|pages|reducers|services|store|modules|dictionaries)(/.*|$)"
-                    ],
-                    // Relative imports.
-                    // Anything that starts with a dot.
-                    ["^\\."]
-                ]
-            }
-        ]
-    }
+    "extends": ["@exabyte-io/eslint-config"]
 }
 

.prettierrc

@@ -4,11 +4,10 @@
     "description": "Application DEfinitions",
     "scripts": {
         "test": "nyc --reporter=text mocha --recursive --bail --require @babel/register/lib --require tests/setup.js tests",
-        "lint": "eslint src tests && prettier --write src tests",
-        "lint:fix": "eslint --fix --cache src tests && prettier --write src tests",
+        "lint": "eslint src tests",
+        "lint:fix": "eslint --fix --cache src tests",
         "transpile": "babel --out-dir dist src",
         "postinstall": "npm run transpile",
-        "prettier": "prettier --check src tests",
         "prepare": "husky install"
     },
     "repository": {
@@ -46,16 +45,15 @@
     },
     "devDependencies": {
         "@exabyte-io/code.js": "2022.11.11-0",
+        "@exabyte-io/eslint-config": "^2022.11.16-0",
         "@exabyte-io/made.js": "2022.6.15-0",
         "chai": "^4.3.4",
         "eslint": "7.32.0",
         "eslint-config-airbnb": "19.0.2",
-        "eslint-config-prettier": "8.3.0",
-        "eslint-plugin-react": "7.30.0",
         "eslint-plugin-import": "2.25.3",
         "eslint-plugin-jsdoc": "37.1.0",
         "eslint-plugin-jsx-a11y": "6.5.1",
-        "eslint-plugin-prettier": "4.2.1",
+        "eslint-plugin-react": "7.30.0",
         "eslint-plugin-simple-import-sort": "7.0.0",
         "husky": "^7.0.4",
         "lint-staged": "^12.1.2",
@@ -71,7 +69,6 @@
         "node": ">=12.0.0"
     },
     "lint-staged": {
-        "*.js": "eslint --cache --fix",
-        "*.{js,css}": "prettier --write"
+        "*.js": "eslint --cache --fix"
     }
 }

package-lock.json

@@ -1,36 +1,35 @@
-import lodash from "lodash";
-import { getAppTree, getAppData, allApplications } from "@exabyte-io/application-flavors.js";
+import { allApplications, getAppData, getAppTree } from "@exabyte-io/application-flavors.js";
 import { NamedDefaultableInMemoryEntity } from "@exabyte-io/code.js/dist/entity";
+import lodash from "lodash";
 
 import { Executable } from "./executable";
 import { getApplicationConfig, getExecutableConfig } from "./tree";
 
-
 export class Application extends NamedDefaultableInMemoryEntity {
     static Executable = Executable;
 
     constructor(config) {
         const staticConfig = getApplicationConfig(config);
-        super({...staticConfig, ...config});
+        super({ ...staticConfig, ...config });
     }
 
     // TODO: extract this from application-flavors "global" default config for espresso 5.4.0
     static get defaultConfig() {
         return {
-            name: 'espresso',
-            shortName: 'qe',
-            version: '5.4.0',
-            summary: 'Quantum Espresso',
-            build: 'Default',
-        }
+            name: "espresso",
+            shortName: "qe",
+            version: "5.4.0",
+            summary: "Quantum Espresso",
+            build: "Default",
+        };
     }
 
     static create(config) {
         return this.createFromNameVersionBuild(config);
     }
 
-    static createFromNameVersionBuild({name, version = null, build = "Default"}) {
-        return new Application({name, version, build});
+    static createFromNameVersionBuild({ name, version = null, build = "Default" }) {
+        return new Application({ name, version, build });
     }
 
     getExecutables() {
@@ -39,15 +38,15 @@ export class Application extends NamedDefaultableInMemoryEntity {
 
     getBuilds() {
         const data = getAppData(this.prop("name"));
-        const {versions} = data;
+        const { versions } = data;
         const builds = ["Default"];
         versions.map((v) => v.build && builds.push(v.build));
         return lodash.uniq(builds);
     }
 
     getVersions() {
         const data = getAppData(this.prop("name"));
-        const {versions} = data;
+        const { versions } = data;
         const these = versions.map((v) => v.version);
         return lodash.uniq(these);
     }
@@ -61,7 +60,7 @@ export class Application extends NamedDefaultableInMemoryEntity {
             getExecutableConfig({
                 appName: this.prop("name"),
                 execName: name,
-            })
+            }),
         );
     }
 
@@ -74,8 +73,9 @@ export class Application extends NamedDefaultableInMemoryEntity {
     }
 
     // override upon inheritance
+    // eslint-disable-next-line class-methods-use-this
     get allowedModelTypes() {
-        return []
+        return [];
     }
 
     get summary() {
@@ -96,11 +96,11 @@ export class Application extends NamedDefaultableInMemoryEntity {
 
     get executables() {
         const tree = getAppTree(this.prop("name"));
-        return Object.keys(tree).map(key => {
+        return Object.keys(tree).map((key) => {
             return new this.constructor.Executable(
-                Object.assign({}, tree[key], {name: key})
-            )
-        })
+                { ...tree[key], name: key },
+            );
+        });
     }
 
     get hasAdvancedComputeOptions() {
@@ -110,5 +110,4 @@ export class Application extends NamedDefaultableInMemoryEntity {
     get isLicensed() {
         return this.prop("isLicensed");
     }
-
 }

package.json

@@ -1,4 +1,4 @@
 export { NWChemTotalEnergyContextProvider } from "./context/providers/nwchem/providers";
 export { QEPWXContextProvider, QENEBContextProvider } from "./context/providers/espresso/providers";
 export { VASPContextProvider, VASPNEBContextProvider } from "./context/providers/vasp/providers";
-export { ExecutableContextProvider } from "./context/providers"
+export { ExecutableContextProvider } from "./context/providers";

src/application.js

@@ -4,7 +4,7 @@ export class ExecutableContextProvider extends ContextProvider {
     constructor(config) {
         super({
             ...config,
-            domain: "executable"
+            domain: "executable",
         });
     }
 }

src/context.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 import {
     JobContextMixin,
     MaterialContextMixin,

src/context/providers.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 import {
     JobContextMixin,
     MaterialContextMixin,

src/context/providers/espresso/providers.js

@@ -1,14 +1,10 @@
-import { mix } from "mixwith";
 import { NamedDefaultableInMemoryEntity, RuntimeItemsMixin } from "@exabyte-io/code.js/dist/entity";
+import { mix } from "mixwith";
+
 import { Template } from "./template";
 
 export class Flavor extends mix(NamedDefaultableInMemoryEntity).with(RuntimeItemsMixin) {
-
-    constructor(config) {
-        super(config);
-    }
-
-    get input() { return this.prop("input", []) }
+    get input() { return this.prop("input", []); }
 
     // TODO : prevent this from running in client
     get inputAsTemplates() {
@@ -26,8 +22,11 @@ export class Flavor extends mix(NamedDefaultableInMemoryEntity).with(RuntimeItem
         });
     }
 
-    getInputAsRenderedTemplates(context) {return this.inputAsTemplates.map(t => t.getRenderedJSON(context))}
-
-    get disableRenderMaterials() {return this.prop("isMultiMaterial", false)}
+    getInputAsRenderedTemplates(context) {
+        return this.inputAsTemplates.map((t) => t.getRenderedJSON(context));
+    }
 
+    get disableRenderMaterials() {
+        return this.prop("isMultiMaterial", false);
+    }
 }