Address remaining diffs noted #821 (#824)

* Add syncs to WallMask

* Bug fix for ordinals other than 0 for slip stress model

* Remove unnecessary mod/sync

Co-authored-by: Philip Sakievich <psakiev@sanida.gov>

Author: psakievich

src/edge_kernels/MomentumABLWallShearStressEdgeKernel.C

@@ -57,15 +57,13 @@ MomentumABLWallShearStressEdgeKernel<BcAlgTraits>::execute(
   const auto& v_areavec = scratchViews.get_scratch_view_2D(exposedAreaVec_);
   const auto& v_wallshearstress = scratchViews.get_scratch_view_2D(wallShearStress_);
 
-  const int* ipNodeMap = meFC_->ipNodeMap();
-
   for (int ip = 0; ip < BcAlgTraits::numFaceIp_; ++ip) {
 
     // Decide which node the shear stress will be applied to
     // rowBase is the first row in the matrix associated with the velocity for this node
-    const int rowBase = slip_ 
-      ? (ipNodeMap[ip] * BcAlgTraits::nDim_) 
-      : (meSCS_->opposingNodes(elemFaceOrdinal, ip) * BcAlgTraits::nDim_);
+    const int rowBase =
+      slip_ ? (meSCS_->ipNodeMap(elemFaceOrdinal)[ip] * BcAlgTraits::nDim_)
+            : (meSCS_->opposingNodes(elemFaceOrdinal, ip) * BcAlgTraits::nDim_);
 
     DoubleType amag = 0.0;
     for (int d=0; d < BcAlgTraits::nDim_; ++d) {

src/ngp_algorithms/MomentumABLWallFuncMaskUtil.C

@@ -33,7 +33,7 @@ MomentumABLWallFuncMaskUtil::execute()
   const auto& meta     = realm_.meta_data();
   const auto ngpMesh   = realm_.ngp_mesh();
   const auto& fieldMgr = realm_.ngp_field_manager();
-  const auto myNodeMask    = fieldMgr.get_field<double>(maskNodeIndex_);
+  auto myNodeMask = fieldMgr.get_field<double>(maskNodeIndex_);
 
   const stk::mesh::Selector sel = (meta.locally_owned_part() | meta.globally_shared_part()) &
                                   stk::mesh::selectUnion(partVec_) &
@@ -45,6 +45,7 @@ MomentumABLWallFuncMaskUtil::execute()
      KOKKOS_LAMBDA(const Traits::MeshIndex& meshIdx) {
        myNodeMask.get(meshIdx, 0) = 0;
      });
+  myNodeMask.modify_on_device();
 }
 
 }