Add WinEvents needed to track caret under latest Excel 2016

Author: govert

Source/ExcelDna.IntelliSense/Providers/LoaderNotification.cs

@@ -78,6 +78,8 @@ enum NtStatus : uint
         IntPtr _cookie;
         LdrNotification _notificationDelegate;
 
+        // NOTE: We might try to set an Environment Variable to disable the Managed Debugging Assistant
+        // https://docs.microsoft.com/en-us/dotnet/framework/debug-trace-profile/diagnosing-errors-with-managed-debugging-assistants
         public LoaderNotification()
         {
             IntPtr context = IntPtr.Zero; // new IntPtr(12345);

Source/ExcelDna.IntelliSense/UIMonitor/FormulaEditWatcher.cs

@@ -95,7 +95,8 @@ void _windowWatcher_FormulaBarWindowChanged(object sender, WindowWatcher.WindowC
                     }
                     else if (e.ObjectId == WindowWatcher.WindowChangedEventArgs.ChangeObjectId.Caret)
                     {
-                        // We expect this on every text change (and it is our only detection of text changes)
+                        // We expect this on every text change
+                        // NOTE: Not anymore after some Excel / Windows update
                         UpdateEditStateDelayed();
                     }
                     else
@@ -138,8 +139,22 @@ void _windowWatcher_FormulaBarWindowChanged(object sender, WindowWatcher.WindowC
                 case WindowWatcher.WindowChangedEventArgs.ChangeType.Hide:
                         Logger.WindowWatcher.Verbose($"FormulaEdit - FormulaBar Hide");
                     break;
+                case WindowWatcher.WindowChangedEventArgs.ChangeType.LocationChange:
+                    if (e.ObjectId == WindowWatcher.WindowChangedEventArgs.ChangeObjectId.Caret)
+                    {
+                        // We expect this on every text change in newer Excel versions
+                        Debug.Print($"-#-#-#- Text Changed ... ");
+                        UpdateEditStateDelayed();
+                    }
+                    else
+                    {
+                        Debug.Print($"-#-#-#- Unexpected WindowsChanged object id: {e.ObjectId}");
+                    }
+                    break;
                 default:
-                    throw new ArgumentOutOfRangeException("Unexpected Window Change Type", "e.Type");
+                    //throw new ArgumentOutOfRangeException("Unexpected Window Change Type", "e.Type");
+                    Logger.WindowWatcher.Verbose($"FormulaEdit - Unexpected Window Change Type: {e.Type}");
+                    break;
             }
         }
 
@@ -157,7 +172,9 @@ void _windowWatcher_InCellEditWindowChanged(object sender, WindowWatcher.WindowC
                     }
                     else if (e.ObjectId == WindowWatcher.WindowChangedEventArgs.ChangeObjectId.Caret)
                     {
-                        // We expect this on every text change (and it is our only detection of text changes)
+                        // We expect this on every text change 
+                        // NOTE: Not anymore after some Excel / Windows update
+                        Debug.Print($"-#-#-#- Text Changed ... ");
                         UpdateEditStateDelayed();
                     }
                     else
@@ -202,8 +219,22 @@ void _windowWatcher_InCellEditWindowChanged(object sender, WindowWatcher.WindowC
                 case WindowWatcher.WindowChangedEventArgs.ChangeType.Hide:
                     Logger.WindowWatcher.Verbose($"FormulaEdit - InCellEdit Hide");
                     break;
+                case WindowWatcher.WindowChangedEventArgs.ChangeType.LocationChange:
+                    if (e.ObjectId == WindowWatcher.WindowChangedEventArgs.ChangeObjectId.Caret)
+                    {
+                        // We expect this on every text change in newer Excel versions
+                        Debug.Print($"-#-#-#- Text Changed ... ");
+                        UpdateEditStateDelayed();
+                    }
+                    else
+                    {
+                        Debug.Print($"-#-#-#- Unexpected WindowsChanged object id: {e.ObjectId}");
+                    }
+                    break;
                 default:
-                    throw new ArgumentOutOfRangeException("Unexpected Window Change Type", "e.Type");
+                    //throw new ArgumentOutOfRangeException("Unexpected Window Change Type", "e.Type");
+                    Logger.WindowWatcher.Verbose($"FormulaEdit - Unexpected Window Change Type: {e.Type}");
+                    break;
             }
         }
 

Source/ExcelDna.IntelliSense/UIMonitor/WinEvents.cs

@@ -52,6 +52,7 @@ enum SetWinEventHookFlags : uint
 
         public enum WinEvent : uint
         {
+            EVENT_MIN = 0x00000001,
             EVENT_OBJECT_CREATE = 0x8000, // hwnd ID idChild is created item
             EVENT_OBJECT_DESTROY = 0x8001, // hwnd ID idChild is destroyed item
             EVENT_OBJECT_SHOW = 0x8002, // hwnd ID idChild is shown item

Source/ExcelDna.IntelliSense/UIMonitor/WindowWatcher.cs

@@ -125,14 +125,15 @@ internal WindowChangedEventArgs(IntPtr windowHandle, WinEventHook.WinEvent winEv
 
         public WindowWatcher(SynchronizationContext syncContextAuto)
         {
-            #pragma warning disable CS0618 // Type or member is obsolete (GetCurrentThreadId) - But for debugging we want to monitor this anyway
+#pragma warning disable CS0618 // Type or member is obsolete (GetCurrentThreadId) - But for debugging we want to monitor this anyway
             // Debug.Print($"### WindowWatcher created on thread: Managed {Thread.CurrentThread.ManagedThreadId}, Native {AppDomain.GetCurrentThreadId()}");
-            #pragma warning restore CS0618 // Type or member is obsolete
+#pragma warning restore CS0618 // Type or member is obsolete
 
             // Using WinEvents instead of Automation so that we can watch top-level window changes, but only from the right (current Excel) process.
             // TODO: We need to dramatically reduce the number of events we grab here...
-            _windowStateChangeHook = new WinEventHook(WinEventHook.WinEvent.EVENT_OBJECT_CREATE, WinEventHook.WinEvent.EVENT_OBJECT_FOCUS, syncContextAuto, IntPtr.Zero);
-//            _windowStateChangeHook = new WinEventHook(WinEventHook.WinEvent.EVENT_OBJECT_CREATE, WinEventHook.WinEvent.EVENT_OBJECT_END, syncContextAuto);
+            _windowStateChangeHook = new WinEventHook(WinEventHook.WinEvent.EVENT_OBJECT_CREATE, WinEventHook.WinEvent.EVENT_OBJECT_LOCATIONCHANGE, syncContextAuto, IntPtr.Zero);
+            // _windowStateChangeHook = new WinEventHook(WinEventHook.WinEvent.EVENT_OBJECT_CREATE, WinEventHook.WinEvent.EVENT_OBJECT_END, syncContextAuto, IntPtr.Zero);
+            // _windowStateChangeHook = new WinEventHook(WinEventHook.WinEvent.EVENT_MIN, WinEventHook.WinEvent.EVENT_AIA_END, syncContextAuto, IntPtr.Zero);
 
             _windowStateChangeHook.WinEventReceived += _windowStateChangeHook_WinEventReceived;
         }