Skip to content

Commit 2e925f7

Browse files
committed
Add some extra tracing for xml errors
1 parent 9670ce9 commit 2e925f7

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

Source/ExcelDna.IntelliSense/Providers/WorkbookIntelliSenseProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public IEnumerable<FunctionInfo> GetFunctionInfos()
7373
var idCheck = regInfo[1, 1] as string;
7474
if (!functionInfoId.Equals(idCheck, StringComparison.OrdinalIgnoreCase))
7575
{
76-
Logger.Provider.Info($"Workbook - Invalid FunctionInfo Identifier: ({idCheck})");
76+
Logger.Provider.Warn($"WorkbookIntelliSenseProvider - Invalid FunctionInfo Identifier: ({idCheck})");
7777
yield break;
7878
}
7979

Source/ExcelDna.IntelliSense/Providers/XmlIntelliSenseProvider.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public void Refresh()
4242
{
4343
xml = File.ReadAllText(_fileName);
4444
}
45-
_intelliSense = XmlIntelliSense.Parse(xml);
45+
_intelliSense = XmlIntelliSense.Parse(xml, _fileName);
4646
if (_intelliSense?.XmlFunctionInfo?.FunctionsList != null)
4747
{
4848
// Fix up SourcePath (is this used?) and HelpTopic
@@ -54,9 +54,9 @@ public void Refresh()
5454
}
5555
}
5656
}
57-
catch // (Exception ex)
57+
catch (Exception ex)
5858
{
59-
// TODO: Log errors
59+
Logger.Provider.Warn($"XmlIntelliSenseProvider - Loading IntelliSense from file {_fileName} failed:\r\n\t{ex.Message}");
6060
_intelliSense = XmlIntelliSense.Empty;
6161
}
6262
}
@@ -169,7 +169,7 @@ public class XmlIntelliSense
169169
public XmlFunctionInfo XmlFunctionInfo;
170170

171171
// returns XmlIntelliSense.Empty on failure
172-
public static XmlIntelliSense Parse(string xmlFunctionInfo)
172+
public static XmlIntelliSense Parse(string xmlFunctionInfo, string logInfo)
173173
{
174174
Initialize();
175175
try
@@ -179,9 +179,9 @@ public static XmlIntelliSense Parse(string xmlFunctionInfo)
179179
return (XmlIntelliSense)_serializer.Deserialize(stringReader);
180180
}
181181
}
182-
catch // (Exception ex)
182+
catch (Exception ex)
183183
{
184-
// TODO: Log errors
184+
Logger.Provider.Warn($"XmlIntelliSense - Parsing Xml IntelliSense from {logInfo} failed:\r\n{ex.Message}");
185185
return Empty;
186186
}
187187
}

0 commit comments

Comments
 (0)