Change ToolTip form and it's handling a bit

Try to understand EXCEL7 window...

Author: govert

Source/ExcelDna.IntelliSense.Host/AddIn.cs

@@ -19,7 +19,7 @@ public void AutoOpen()
 
         public void AutoClose()
         {
-            // CONSIDER: Do we implement an explicit call here, or is the AppDomain Unload event good enough
+            // CONSIDER: Do we implement an explicit call here, or is the AppDomain Unload event good enough?
         }
     }
 }

Source/ExcelDna.IntelliSense.Host/MyFunctions.cs

@@ -1,25 +1,27 @@
-using System;
-using System.ComponentModel;
-using ExcelDna.Integration;
+#if DEBUG
+    using System;
+    using System.ComponentModel;
+    using ExcelDna.Integration;
 
-namespace ExcelDna.CustomAddin
-{
-    // TODO: Remove these functions - they're jsut here for testing...
-    public class MyFunctions
+    namespace ExcelDna.CustomAddin
     {
-        [ExcelFunction(Description = "A useful test function that adds two numbers, and returns the product.")]
-        public static double AddThem(
-            [ExcelArgument(Name = "Augend", Description = "is the first number, to which will be multiplied")] double v1,
-            [ExcelArgument(Name = "Addend", Description = "is the second number that will be multiplied")]     double v2)
+        // These functions - are just here for testing...
+        public class MyFunctions
         {
-            return v1 + v2;
-        }
+            [ExcelFunction(Description = "A useful test function that adds two numbers, and returns the product.")]
+            public static double AddThem(
+                [ExcelArgument(Name = "Augend", Description = "is the first number, to which will be multiplied")] double v1,
+                [ExcelArgument(Name = "Addend", Description = "is the second number that will be multiplied")]     double v2)
+            {
+                return v1 + v2;
+            }
 
-        [Description("Test function for the amazing Excel-DNA IntelliSense feature")]
-        public static string jDummyFunc()
-        {
-            return "Howzit !";
-        }
+            [Description("Test function for the amazing Excel-DNA IntelliSense feature")]
+            public static string jDummyFunc()
+            {
+                return "Howzit !";
+            }
 
+        }
     }
-}
+#endif

Source/ExcelDna.IntelliSense/FormattedText.cs

@@ -1,6 +1,7 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Drawing;
+using System.Linq;
 
 namespace ExcelDna.IntelliSense
 {
@@ -28,6 +29,11 @@ IEnumerator IEnumerable.GetEnumerator()
         {
             return GetEnumerator();
         }
+
+        public override string ToString()
+        {
+            return string.Join("\r\n", _lines.Select(l => l.ToString()));
+        }
     }
 
     class TextLine : IEnumerable<TextRun>
@@ -51,6 +57,11 @@ IEnumerator IEnumerable.GetEnumerator()
         {
             return GetEnumerator();
         }
+
+        public override string ToString()
+        {
+            return string.Concat(_runs.Select(r => r.Text));
+        }
     }
 
     class TextRun

Source/ExcelDna.IntelliSense/IntelliSenseDisplay.cs

@@ -189,14 +189,18 @@ void UpdateMainWindow(IntPtr mainWindow)
         // Runs on the main thread
         void FormulaEditStart()
         {
+            Debug.Print($"IntelliSenseDisplay - FormulaEditStart");
             if (_argumentsToolTip == null)
                 _argumentsToolTip = new ToolTipForm(_mainWindow);
         }
 
         // Runs on the main thread
         void FormulaEditEnd()
         {
-            _argumentsToolTip.Hide();
+            Debug.Print($"IntelliSenseDisplay - FormulaEditEnd");
+            // _argumentsToolTip.Hide();
+            _argumentsToolTip.Dispose();
+            _argumentsToolTip = null;
         }
 
         // Runs on the main thread
@@ -227,21 +231,27 @@ void FormulaEditTextChange(string formulaPrefix, Rect editWindowBounds, Rect exc
             }
 
             // All other paths, we just clear the box
-            _argumentsToolTip.Hide();
+            //_argumentsToolTip.Hide();
+            _argumentsToolTip.Dispose();
+            _argumentsToolTip = null;
         }
 
 
         // Runs on the main thread
         void FunctionListShow()
         {
+            Debug.Print($"IntelliSenseDisplay - FunctionListShow");
             if (_descriptionToolTip == null)
                 _descriptionToolTip = new ToolTipForm(_mainWindow);
         }
 
         // Runs on the main thread
         void FunctionListHide()
         {
-            _descriptionToolTip.Hide();
+            Debug.Print($"IntelliSenseDisplay - FunctionListHide");
+            //_descriptionToolTip.Hide();
+            _descriptionToolTip.Dispose();
+            _descriptionToolTip = null;
         }
 
         // Runs on the main thread
@@ -260,7 +270,7 @@ void FunctionListSelectedItemChange(string selectedItemText, Rect selectedItemBo
             }
             else
             {
-                FunctionListHide();
+                _descriptionToolTip.Hide();
             }
         }
 

Source/ExcelDna.IntelliSense/IntelliSenseServer.cs

@@ -235,9 +235,10 @@ public static RegistrationInfo FromRegistrationString(string registrationString)
                         Version = parts[2]
                     };
                 }
-                catch
+                catch (Exception ex)
                 {
                     // TODO: Log
+                    Debug.Print($"!!! ERROR: Invalid RegistrationString {registrationString}: {ex.Message}");
                     return null;
                 }
             }
@@ -380,10 +381,15 @@ static bool IsVersionMatch(string version, string versionPattern)
         // returns null if there are none registered
         static RegistrationInfo GetHighestPublishedRegistration()
         {
-            return Environment.GetEnvironmentVariable(ServersVariable)
-                              .Split(';')
-                              .Select(str => RegistrationInfo.FromRegistrationString(str))
-                              .Max();
+            var servers = Environment.GetEnvironmentVariable(ServersVariable);
+            if (servers == null)
+            {
+                Debug.Print("!!! ERROR: ServersVariable not set");
+                return null;
+            }
+            return servers.Split(';')
+                          .Select(str => RegistrationInfo.FromRegistrationString(str))
+                          .Max();
         }
         #endregion
 

Source/ExcelDna.IntelliSense/Properties/AssemblyInfo.cs

@@ -32,5 +32,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.0.0.0")]
+[assembly: AssemblyVersion("0.1.*")]
+// [assembly: AssemblyFileVersion("0.0.0.0")]

Source/ExcelDna.IntelliSense/ToolTipForm.cs

@@ -8,6 +8,8 @@
 
 namespace ExcelDna.IntelliSense
 {
+
+    // TODO: Drop shadow: http://stackoverflow.com/questions/16493698/drop-shadow-on-a-borderless-winform
     class ToolTipForm  : Form
     {
         FormattedText _text;
@@ -32,7 +34,7 @@ protected override void DefWndProc(ref Message m)
             const int WM_MOUSEACTIVATE = 0x21;
             const int MA_NOACTIVATE = 0x0003;
 
-            switch(m.Msg)
+            switch (m.Msg)
             {
                 case WM_MOUSEACTIVATE:
                     m.Result = (IntPtr)MA_NOACTIVATE;
@@ -59,10 +61,12 @@ public void ShowToolTip(FormattedText text, int left, int top)
             _text = text;
             if (!Visible)
             {
+                Debug.Print($"Showing ToolTipForm: {_text.ToString()}");
                 ShowToolTip();
             }
             else
             {
+                Debug.Print($"Invalidating ToolTipForm: {_text.ToString()}");
                 Invalidate();
             }
             Left = left;
@@ -100,26 +104,37 @@ protected override bool ShowWithoutActivation
         //    }
         //}
 
-
+        
+        // Sometimes has Invalid Handle error when calling base.CreateParams (called from Invalidate() for some reason)
+        CreateParams _createParams;
         protected override CreateParams CreateParams
         {
             get
             {
-                const int CS_DROPSHADOW = 0x00020000;
-                const int WS_CHILD = 0x40000000;
-                const int WS_EX_TOOLWINDOW = 0x00000080;
-                const int WS_EX_NOACTIVATE = 0x08000000;
-                // NOTE: I've seen exception with invalid handle in the base.CreateParams call here...
-                CreateParams baseParams = base.CreateParams;
-                baseParams.ClassStyle |= CS_DROPSHADOW;
-                baseParams.Style |= WS_CHILD;
-                baseParams.ExStyle |= ( WS_EX_NOACTIVATE | WS_EX_TOOLWINDOW );
-                return baseParams;
+                //if (_createParams == null)
+                {
+                    const int CS_DROPSHADOW = 0x00020000;
+                    const int WS_CHILD = 0x40000000;
+                    const int WS_EX_TOOLWINDOW = 0x00000080;
+                    const int WS_EX_NOACTIVATE = 0x08000000;
+                    // NOTE: I've seen exception with invalid handle in the base.CreateParams call here...
+                    _createParams = base.CreateParams;
+                    _createParams.ClassStyle |= CS_DROPSHADOW;
+                    // baseParams.Style |= WS_CHILD;
+                    _createParams.ExStyle |= (WS_EX_NOACTIVATE | WS_EX_TOOLWINDOW);
+                }
+                return _createParams;
             }
         }
 
+        protected override void OnHandleDestroyed(EventArgs e)
+        {
+            base.OnHandleDestroyed(e);
+        }
+
         protected override void OnPaint(PaintEventArgs e)
         {
+            Debug.Print($"Painting ToolTipForm: {_text.ToString()}");
             const int leftPadding = 3;
             const int linePadding = 2;
             const int widthPadding = 10;
@@ -233,6 +248,8 @@ void InitializeComponent()
 
         }
 
+        
+        
         class Win32Window : IWin32Window
         {
             public IntPtr Handle

Source/ExcelDna.IntelliSense/Watchers.cs

@@ -104,6 +104,7 @@ void _windowStateChangeHook_WinEventReceived(object sender, WinEventHook.WinEven
             switch (className)
             {
                 case _mainWindowClass:
+                case _mainWindowClass2:
                     if (e.EventType == WinEventHook.WinEvent.EVENT_OBJECT_CREATE || 
                         e.EventType == WinEventHook.WinEvent.EVENT_OBJECT_DESTROY ||
                         e.EventType == WinEventHook.WinEvent.EVENT_OBJECT_SHOW ||
@@ -205,6 +206,7 @@ void _windowStateChangeHook_WinEventReceived(object sender, WinEventHook.WinEven
             }
         }
 
+        // Runs on our automation thread
         void UpdateMainWindow(IntPtr hWnd)
         {
             if (MainWindow != hWnd)
@@ -218,37 +220,46 @@ void UpdateMainWindow(IntPtr hWnd)
             {
                 // Either fresh window, or children not yet set up
 
-                // Search for formulaBar
-                // I've seen ElementNotAvailbleException here during shutdown
-                AutomationElement mainWindow = AutomationElement.FromHandle(hWnd);
+                //try // Anything can go wrong here, e.g. we're shutting down on the main thread
+                //{
+
+                    // Search for formulaBar
+
+                    AutomationElement mainWindow = AutomationElement.FromHandle(hWnd);
 #if DEBUG
-                var mainChildren = mainWindow.FindAll(TreeScope.Children, Condition.TrueCondition);
-                foreach (AutomationElement child in mainChildren)
-                {
-                    var hWndChild = (IntPtr)(int)child.GetCurrentPropertyValue(AutomationElement.NativeWindowHandleProperty);
-                    var classChild = (string)child.GetCurrentPropertyValue(AutomationElement.ClassNameProperty);
-                    // Debug.Print($"Child: {hWndChild}, Class: {classChild}");
-                }
+                    var mainChildren = mainWindow.FindAll(TreeScope.Children, Condition.TrueCondition);
+                    foreach (AutomationElement child in mainChildren)
+                    {
+                        var hWndChild = (IntPtr)(int)child.GetCurrentPropertyValue(AutomationElement.NativeWindowHandleProperty);
+                        var classChild = (string)child.GetCurrentPropertyValue(AutomationElement.ClassNameProperty);
+                        // Debug.Print($"Child: {hWndChild}, Class: {classChild}");
+                    }
 #endif
-                AutomationElement formulaBar = mainWindow.FindFirst(TreeScope.Children,
-                    new PropertyCondition(AutomationElement.ClassNameProperty, _formulaBarClass));
-                if (formulaBar != null)
-                {
-                    FormulaBarWindow = (IntPtr)(int)formulaBar.GetCurrentPropertyValue(AutomationElement.NativeWindowHandleProperty);
+                    AutomationElement formulaBar = mainWindow.FindFirst(TreeScope.Children,
+                        new PropertyCondition(AutomationElement.ClassNameProperty, _formulaBarClass));
+                    if (formulaBar != null)
+                    {
+                        FormulaBarWindow = (IntPtr)(int)formulaBar.GetCurrentPropertyValue(AutomationElement.NativeWindowHandleProperty);
 
-                    // CONSIDER:
-                    //  Watch WindowClose event for MainWindow?
+                        // CONSIDER:
+                        //  Watch WindowClose event for MainWindow?
 
-                    FormulaBarWindowChanged?.Invoke(this, EventArgs.Empty);
-                }
-                else
-                {
-                    // Debug.Print("Could not get FormulaBar!");
-                }
+                        FormulaBarWindowChanged?.Invoke(this, EventArgs.Empty);
+                    }
+                    else
+                    {
+                        // Debug.Print("Could not get FormulaBar!");
+                    }
+                //}
+                //catch (Exception ex)
+                //{
+
+                //}
             }
         }
 
         const string _mainWindowClass = "XLMAIN";
+        const string _mainWindowClass2 = "EXCEL7";  // What / when ????????
         const string _formulaBarClass = "EXCEL<";
         const string _inCellEditClass = "EXCEL6";
         const string _popupListClass = "__XLACOOUTER";