Fix possible crash in IntelliSenseServer.Uninstall()

lanfeust69 · web-flow · commit d3e0a40faca4 · 2019-05-22T10:24:55.000+02:00
If intellisense is disabled, IntelliSenseServer.Install() returns early,
but not IntelliSenseServer.Uninstall(), which will then throw a
NullReferenceException because environment variable
EXCELDNA_INTELLISENSE_SERVERS has not been set.
diff --git a/Source/ExcelDna.IntelliSense/IntelliSenseServer.cs b/Source/ExcelDna.IntelliSense/IntelliSenseServer.cs
@@ -111,6 +111,8 @@ public static void Install()
         public static void Uninstall()
         {
             Logger.Initialization.Info($"IntelliSenseServer.Uninstall Begin: Version {ServerVersion} in {AppDomain.CurrentDomain.FriendlyName}");
+            if (IsDisabled())
+                return;
 
             UnpublishRegistration();
             if (_isActive)

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,8 @@ public static void Install()`
`111`	`111`	`public static void Uninstall()`
`112`	`112`	`{`
`113`	`113`	`Logger.Initialization.Info($"IntelliSenseServer.Uninstall Begin: Version {ServerVersion} in {AppDomain.CurrentDomain.FriendlyName}");`
	`114`	`+ if (IsDisabled())`
	`115`	`+ return;`
`114`	`116`
`115`	`117`	`UnpublishRegistration();`
`116`	`118`	`if (_isActive)`