Updated ribbon event procedures

Author: aduguid

VB/Ribbon.xml

@@ -38,7 +38,8 @@
 							size="large"
 							onAction="OnAction"
 							getImage="GetButtonImage"
-							screentip="This will ping the visible servers in the selected data table."
+							screentip="Ping Servers"
+							supertip="This will ping the visible servers in the selected data table."
 							/>
 					<separator
 							id="separator2"
@@ -51,7 +52,8 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the server column."
+							screentip="Server Name"
+							supertip="This is the column name for the server column."
 							/>
 					<comboBox
 							id="cboPingName"
@@ -61,7 +63,8 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the ping column. If the column doesn't exist, it will be created."
+							screentip="Ping Results"
+							supertip="This is the column name for the ping column. If the column doesn't exist, it will be created."
 							/>
 				</group>
 				<group
@@ -89,7 +92,8 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the server column."
+							screentip="Server Name"
+							supertip="This is the column name for the server column."
 							/>
 					<comboBox
 							id="cboRdgDescription"
@@ -99,7 +103,8 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the server description column."
+							screentip="Server Description"
+							supertip="This is the column name for the server description column."
 							/>
 					<comboBox
 							id="cboRdgComment"
@@ -109,7 +114,8 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the server comment column."
+							screentip="Server Comment"
+							supertip="This is the column name for the server comment column."
 							/>
 					<separator
 							id="separator4"
@@ -122,15 +128,17 @@
 							getItemCount="GetItemCount"
 							getItemLabel="GetItemLabel"
 							sizeString= "XXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the column name for the server group column."
+							screentip="Server Group"
+							supertip="This is the column name for the server group column."
 							/>
 					<editBox
 							id="txtFileName"
 							label="File Name: "
 							onChange="OnChange"
 							getText="GetLabelText"
 							sizeString= "XXXXXXXXXXXXXXXXXXXXXX"
-							screentip="This is the file path for the Remote Desktop Manager file."
+							screentip="Find Date Format"
+							supertip="This is the file path for the Remote Desktop Manager file."
 							/>
 				</group>
 				<group 

VB/Scripts/ErrorHandler.vb

@@ -14,12 +14,12 @@ Namespace Scripts
 
         Private Shared ReadOnly log As ILog = LogManager.GetLogger(GetType(ErrorHandler))
 
-        Public Shared Sub CreateLogRecord()
+        Public Shared Sub CreateLogRecord(Optional ByVal message As String = "")
             Try
                 Dim sf As New System.Diagnostics.StackFrame(1)
                 Dim caller As System.Reflection.MethodBase = sf.GetMethod()
                 Dim currentProcedure As String = (caller.Name).Trim()
-                log.Info((Convert.ToString("[PROCEDURE]=|") & currentProcedure) + "|[USER NAME]=|" + Environment.UserName + "|[MACHINE NAME]=|" + Environment.MachineName)
+                log.Info("[PROCEDURE]=|" + currentProcedure + "|[USER NAME]=|" + Environment.UserName + "|[MACHINE NAME]=|" + Environment.MachineName + "|[MESSAGE]=|" + message)
 
             Catch ex As Exception
                 ErrorHandler.DisplayMessage(ex)
@@ -34,11 +34,10 @@ Namespace Scripts
             Dim currentFileName As String = "" 'AssemblyInfo.GetCurrentFileName()
             Dim errorMessageDescription As String = ex.ToString()
             errorMessageDescription = System.Text.RegularExpressions.Regex.Replace(errorMessageDescription, "\r\n+", " ")
-            'the carriage returns were messing up my log file
             Dim msg As String = "Contact your system administrator. A record has been created in the log file." + Environment.NewLine
             msg += (Convert.ToString("Procedure: ") & currentProcedure) + Environment.NewLine
             msg += "Description: " + ex.ToString() + Environment.NewLine
-            log.[Error](Convert.ToString((Convert.ToString((Convert.ToString("[PROCEDURE]=|") & currentProcedure) + "|[USER NAME]=|" + Environment.UserName + "|[MACHINE NAME]=|" + Environment.MachineName + "|[FILE NAME]=|") & currentFileName) + "|[DESCRIPTION]=|") & errorMessageDescription)
+            log.Error("[PROCEDURE]=|" + currentProcedure + "|[USER NAME]=|" + Environment.UserName + "|[MACHINE NAME]=|" + Environment.MachineName + "|[DESCRIPTION]=|" + errorMessageDescription)
             If isSilent = False Then
                 MessageBox.Show(msg, "Unexpected Error", MessageBoxButtons.OK, MessageBoxIcon.Error)
             End If

VB/Scripts/Ribbon.vb

@@ -36,6 +36,7 @@ Namespace Scripts
 
         Public Sub Ribbon_Load(ByVal ribbonUI As Office.IRibbonUI)
             Try
+                ErrorHandler.CreateLogRecord()
                 Me.ribbon = ribbonUI
                 ribbonref = Me
 
@@ -67,44 +68,46 @@ Namespace Scripts
 
         End Function
 
-        Public Sub GetItemLabel(ByVal control As Office.IRibbonControl, index As Integer, ByRef returnedVal As String)
+        Public Function GetItemLabel(control As Office.IRibbonControl, index As Integer) As String
             Dim tbl As Excel.ListObject = Globals.ThisAddIn.Application.ActiveCell.ActiveCell.ListObject
             Try
                 If (tbl Is Nothing) Or index = 0 Then
-                    returnedVal = ""
-                    Exit Sub
+                    ErrorHandler.CreateLogRecord("EMPTY")
+                    Return String.Empty
                 End If
-                returnedVal = tbl.ListColumns(index).Name
+                ErrorHandler.CreateLogRecord(tbl.ListColumns(index).Name)
+                Return tbl.ListColumns(index).Name
 
             Catch ex As Exception
                 Call ErrorHandler.DisplayMessage(ex)
-                returnedVal = "ERROR"
+                Return "ERROR"
 
             Finally
                 tbl = Nothing
 
             End Try
 
-        End Sub
+        End Function
 
-        Private Sub GetItemCount(ByVal control As Office.IRibbonControl, ByRef Count As Integer)
+        Public Function GetItemCount(control As Office.IRibbonControl) As Integer
             Dim tbl As Excel.ListObject = Globals.ThisAddIn.Application.ActiveCell.ListObject
             Try
                 If (tbl Is Nothing) Then
-                    Count = 2
+                    Return 2
                 Else
-                    Count = tbl.ListColumns.Count + 1
+                    Return tbl.ListColumns.Count + 1
                 End If
 
             Catch ex As Exception
                 Call ErrorHandler.DisplayMessage(ex)
+                Return 0
 
             Finally
                 tbl = Nothing
 
             End Try
 
-        End Sub
+        End Function
 
         Public Function GetLabelText(ByVal control As Office.IRibbonControl) As String
             Try