Skip to content

Skipping decoding BlockPlacement packet #260

@sqdKaee

Description

@sqdKaee

Describe the bug
When interacting with something without an item in your hand you're getting kicked from the server

To Reproduce
Steps to reproduce the behavior:

  1. Install protocolize + legacy module
  2. Join with 1.8.9 client
  3. Interact with something without having anything in your hand
  4. See error in the console

Proxy environment
Waterfall latest

Minecraft versions used
1.8.9 client/server

Error

[10:14:22] [Netty Worker IO Thread #1/ERROR] [Protocolize]: Skipping decoding BlockPlacement packet
java.lang.NullPointerException: Cannot invoke "dev.simplix.protocolize.data.ItemType.name()" because the return value of "dev.simplix.protocolize.api.item.ItemStack.itemType()" is null
	at dev.simplix.protocolize.data.packets.BlockPlacement.read(BlockPlacement.java:121) ~[?:?]
	at dev.simplix.protocolize.bungee.packet.BungeeCordProtocolizePacket.read(BungeeCordProtocolizePacket.java:57) ~[?:?]
	at net.md_5.bungee.protocol.DefinedPacket.read(DefinedPacket.java:534) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:62) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at net.md_5.bungee.protocol.MinecraftDecoder.decode(MinecraftDecoder.java:13) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:91) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:107) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1357) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:868) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[waterfall.jar:git:Waterfall-Bootstrap:1.21-R0.1-SNAPSHOT:9ab9e2b:582]
	at java.lang.Thread.run(Thread.java:1583) [?:?]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions