feat: reveal image not found error (#739)

* feat: reveal image not found error

* print ConfigError cause

* capitalize the cause sentense

Author: reliveyy

images/utils/launcher/__init__.py

@@ -248,6 +248,15 @@ def start(self):
         self.shell.start(f"{self.config.network} > ", self.handle_command)
 
 
+def print_config_error_cause(e: ConfigError) -> None:
+    if e.__cause__:
+        cause = str(e.__cause__)
+        if cause == "":
+            print(type(e.__cause__))
+        else:
+            print(cause.capitalize())
+
+
 class Launcher:
     def __init__(self):
         self.logger = logging.getLogger("launcher.Launcher")
@@ -266,17 +275,17 @@ def launch(self):
             print()
         except ConfigError as e:
             if e.scope == ConfigErrorScope.COMMAND_LINE_ARGS:
-                print("❌ Failed to parse command-line arguments, exiting.")
-                print(f"Error details: {e.__cause__}")
+                print("Failed to parse command-line arguments, exiting.")
+                print_config_error_cause(e)
             elif e.scope == ConfigErrorScope.GENERAL_CONF:
-                print("❌ Failed to parse config file {}, exiting.".format(e.conf_file))
-                print(f"Error details: {e.__cause__}")
+                print("Failed to parse config file {}, exiting.".format(e.conf_file))
+                print_config_error_cause(e)
             elif e.scope == ConfigErrorScope.NETWORK_CONF:
-                print("❌ Failed to parse config file {}, exiting.".format(e.conf_file))
-                print(f"Error details: {e.__cause__}")
+                print("Failed to parse config file {}, exiting.".format(e.conf_file))
+                print_config_error_cause(e)
         except FatalError as e:
             if config and config.logfile:
-                print(f"❌ Error: {e}. For more details, see {config.logfile}")
+                print("{}. For more details, see {}".format(e, config.logfile))
             else:
                 traceback.print_exc()
         except Exception:  # exclude system exceptions like SystemExit

images/utils/launcher/node/__init__.py

@@ -209,13 +209,13 @@ def down(self):
 
     def _display_container_status_text(self, status):
         if status == "missing":
-            return "missing"
+            return "create"
         elif status == "outdated":
-            return "outdated"
+            return "recreate"
         elif status == "external_with_container":
-            return "non-native"
+            return "remove"
         elif status == "disabled_with_container":
-            return "disabled"
+            return "remove"
 
     def _readable_details(self, details):
         if not details:
@@ -244,8 +244,8 @@ def update(self) -> bool:
                 outdated = True
                 image_outdated = True
             elif status == "UNAVAILABLE":
-                all_unavailable_images = [x for x in images if x.status == "UNAVAILABLE"]
-                raise FatalError("Image(s) not available: %r" % all_unavailable_images)
+                all_unavailable_images = [x.name for x in images if x.status == "UNAVAILABLE"]
+                raise FatalError("Image(s) not found: %s" % ", ".join(all_unavailable_images))
 
         # Step 2. check all containers
         containers = self.nodes.values()

images/utils/launcher/node/image.py

@@ -212,27 +212,35 @@ def fetch_cloud_metadata(self):
         except:
             self.logger.exception("Failed to fetch cloud image metadata")
 
-    def fetch_cloud_metadata_wrapper(self):
-        for i in range(3):
-            metadata = self.fetch_cloud_metadata()
-            if metadata:
-                return metadata
-            self.logger.exception("Image not found on cloud: %s (retry in 10 seconds)" % self.name)
-            time.sleep(10)
-        raise RuntimeError("Failed to fetch cloud image metadata (3 times): %s" % self.name)
-
-    def get_status(self):
+    def get_status(self) -> str:
+        """Get image update status
+
+        :return: image status
+        - UP_TO_DATE: The local image is the same as the cloud.
+        - LOCAL_OUTDATED: The local image hash is different from the cloud.
+        - LOCAL_NEWER: The local image is created after the cloud.
+        - LOCAL_MISSING: The cloud image exists but no local image.
+        - LOCAL_ONLY: The image only exists locally.
+        - UNAVAILABLE: The image is not found locally or remotely.
+        """
         if self.node.node_config["use_local_image"]:
             self.cloud_metadata = None
             return "LOCAL_NEWER"
 
-        self.cloud_metadata = self.fetch_cloud_metadata_wrapper()
         local = self.local_metadata
+
+        self.cloud_metadata = self.fetch_cloud_metadata()
         cloud = self.cloud_metadata
-        assert cloud
+
+        if not local and not cloud:
+            return "UNAVAILABLE"
+
+        if local and not cloud:
+            return "LOCAL_ONLY"
 
         if not local and cloud:
             return "LOCAL_MISSING"
+
         if local.digest == cloud.digest:
             return "UP_TO_DATE"
         else:
@@ -243,13 +251,13 @@ def status_message(self):
         if self.status == "UNAVAILABLE":
             return "unavailable"
         elif self.status == "LOCAL_ONLY":
-            return "local"
+            return "using local version"
         elif self.status == "LOCAL_MISSING":
-            return "missing"
+            return "pull"
         elif self.status == "LOCAL_NEWER":
-            return "newer"
+            return "using local version"
         elif self.status == "LOCAL_OUTDATED":
-            return "outdated"
+            return "pull"
         elif self.status == "UP_TO_DATE":
             return "up-to-date"
 
@@ -320,24 +328,16 @@ def check_for_updates(self) -> List[Image]:
         images = [image for image in images if image.node.mode == "native" and not image.node.disabled]
 
         def print_failed(failed):
-            for image, error in failed:
-                error_message = get_useful_error_message(error)
-                if error_message == "timeout":
-                    raise FatalError("Timeout error: Couldn't connect to Docker to check for updates. Please check your internet connection and https://status.docker.com/.")
-            print("Failed to check for image updates.")
-            for image, error in failed:
-                error_message = get_useful_error_message(error)
-                print("- {}: {}".format(image.name, error_message))
+            pass
 
         def try_again():
-            answer = self.shell.yes_or_no("Try again?")
-            return answer == "yes"
+            return False
 
         parallel_execute(images, lambda i: i.check_for_updates(), 30, print_failed, try_again)
 
         return images
 
-    def update_images(self):
+    def update_images(self) -> None:
         for image in self.images.values():
             status = image.status
             pull_image = image.pull_image