clang-tidy: default member init

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

src/cr2header_int.cpp

@@ -3,7 +3,7 @@
 #include "cr2header_int.hpp"
 
 namespace Exiv2::Internal {
-Cr2Header::Cr2Header(ByteOrder byteOrder) : TiffHeaderBase(42, 16, byteOrder, 0x00000010), offset2_(0x00000000) {
+Cr2Header::Cr2Header(ByteOrder byteOrder) : TiffHeaderBase(42, 16, byteOrder, 0x00000010) {
 }
 
 bool Cr2Header::read(const byte* pData, size_t size) {

src/cr2header_int.hpp

@@ -49,7 +49,7 @@ class Cr2Header : public TiffHeaderBase {
 
  private:
   // DATA
-  uint32_t offset2_;                         //!< Bytes 12-15 from the header
+  uint32_t offset2_{0x00000000};             //!< Bytes 12-15 from the header
   static constexpr auto cr2sig_ = "CR\2\0";  //!< Signature for CR2 type TIFF
 };                                           // class Cr2Header
 

src/makernote_int.cpp

@@ -274,7 +274,7 @@ size_t FujiMnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-FujiMnHeader::FujiMnHeader() : start_(0) {
+FujiMnHeader::FujiMnHeader() {
   read(signature_, sizeOfSignature(), byteOrder_);
 }
 
@@ -316,7 +316,7 @@ size_t Nikon2MnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-Nikon2MnHeader::Nikon2MnHeader() : start_(0) {
+Nikon2MnHeader::Nikon2MnHeader() {
   read(signature_, sizeOfSignature(), invalidByteOrder);
 }
 
@@ -351,7 +351,7 @@ size_t Nikon3MnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-Nikon3MnHeader::Nikon3MnHeader() : byteOrder_(invalidByteOrder), start_(sizeOfSignature()) {
+Nikon3MnHeader::Nikon3MnHeader() : start_(sizeOfSignature()) {
   buf_.alloc(sizeOfSignature());
   std::copy_n(signature_, buf_.size(), buf_.data());
 }
@@ -406,7 +406,7 @@ size_t PanasonicMnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-PanasonicMnHeader::PanasonicMnHeader() : start_(0) {
+PanasonicMnHeader::PanasonicMnHeader() {
   read(signature_, sizeOfSignature(), invalidByteOrder);
 }
 
@@ -527,7 +527,7 @@ size_t SigmaMnHeader::sizeOfSignature() {
   return sizeof(signature1_);
 }
 
-SigmaMnHeader::SigmaMnHeader() : start_(0) {
+SigmaMnHeader::SigmaMnHeader() {
   read(signature1_, sizeOfSignature(), invalidByteOrder);
 }
 
@@ -561,7 +561,7 @@ size_t SonyMnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-SonyMnHeader::SonyMnHeader() : start_(0) {
+SonyMnHeader::SonyMnHeader() {
   read(signature_, sizeOfSignature(), invalidByteOrder);
 }
 
@@ -596,7 +596,7 @@ size_t Casio2MnHeader::sizeOfSignature() {
   return sizeof(signature_);
 }
 
-Casio2MnHeader::Casio2MnHeader() : start_(0) {
+Casio2MnHeader::Casio2MnHeader() {
   read(signature_, sizeOfSignature(), invalidByteOrder);
 }
 

src/makernote_int.hpp

@@ -250,7 +250,7 @@ class FujiMnHeader : public MnHeader {
   DataBuf header_;                    //!< Data buffer for the makernote header
   static const byte signature_[];     //!< Fujifilm makernote header signature
   static const ByteOrder byteOrder_;  //!< Byteorder for makernote (always II)
-  uint32_t start_;                    //!< Start of the mn IFD rel. to mn start
+  uint32_t start_{0};                 //!< Start of the mn IFD rel. to mn start
 
 };  // class FujiMnHeader
 
@@ -279,7 +279,7 @@ class Nikon2MnHeader : public MnHeader {
 
  private:
   DataBuf buf_;                    //!< Raw header data
-  size_t start_;                   //!< Start of the mn IFD rel. to mn start
+  size_t start_{0};                //!< Start of the mn IFD rel. to mn start
   static const byte signature_[];  //!< Nikon 2 makernote header signature
 
 };  // class Nikon2MnHeader
@@ -311,10 +311,10 @@ class Nikon3MnHeader : public MnHeader {
   static size_t sizeOfSignature();
 
  private:
-  DataBuf buf_;                    //!< Raw header data
-  ByteOrder byteOrder_;            //!< Byteorder for makernote
-  size_t start_;                   //!< Start of the mn IFD rel. to mn start
-  static const byte signature_[];  //!< Nikon 3 makernote header signature
+  DataBuf buf_;                            //!< Raw header data
+  ByteOrder byteOrder_{invalidByteOrder};  //!< Byteorder for makernote
+  size_t start_;                           //!< Start of the mn IFD rel. to mn start
+  static const byte signature_[];          //!< Nikon 3 makernote header signature
 
 };  // class Nikon3MnHeader
 
@@ -343,7 +343,7 @@ class PanasonicMnHeader : public MnHeader {
 
  private:
   DataBuf buf_;                    //!< Raw header data
-  size_t start_;                   //!< Start of the mn IFD rel. to mn start
+  size_t start_{0};                //!< Start of the mn IFD rel. to mn start
   static const byte signature_[];  //!< Panasonic makernote header signature
 
 };  // class PanasonicMnHeader
@@ -453,7 +453,7 @@ class SigmaMnHeader : public MnHeader {
 
  private:
   DataBuf buf_;                     //!< Raw header data
-  size_t start_;                    //!< Start of the mn IFD rel. to mn start
+  size_t start_{0};                 //!< Start of the mn IFD rel. to mn start
   static const byte signature1_[];  //!< Sigma makernote header signature 1
   static const byte signature2_[];  //!< Sigma makernote header signature 2
 
@@ -484,7 +484,7 @@ class SonyMnHeader : public MnHeader {
 
  private:
   DataBuf buf_;                    //!< Raw header data
-  size_t start_;                   //!< Start of the mn IFD rel. to mn start
+  size_t start_{0};                //!< Start of the mn IFD rel. to mn start
   static const byte signature_[];  //!< Sony makernote header signature
 
 };  // class SonyMnHeader
@@ -515,7 +515,7 @@ class Casio2MnHeader : public MnHeader {
 
  private:
   DataBuf buf_;                       //!< Raw header data
-  size_t start_;                      //!< Start of the mn IFD rel. to mn start
+  size_t start_{0};                   //!< Start of the mn IFD rel. to mn start
   static const byte signature_[];     //!< Casio makernote header signature
   static const ByteOrder byteOrder_;  //!< Byteorder for makernote (always big endian)
 

src/orfimage_int.cpp

@@ -3,7 +3,7 @@
 #include "orfimage_int.hpp"
 
 namespace Exiv2::Internal {
-OrfHeader::OrfHeader(ByteOrder byteOrder) : TiffHeaderBase(0x4f52, 8, byteOrder, 0x00000008), sig_(0x4f52) {
+OrfHeader::OrfHeader(ByteOrder byteOrder) : TiffHeaderBase(0x4f52, 8, byteOrder, 0x00000008) {
 }
 
 bool OrfHeader::read(const byte* pData, size_t size) {

src/orfimage_int.hpp

@@ -37,8 +37,8 @@ class OrfHeader : public TiffHeaderBase {
   //@}
  private:
   // DATA
-  uint16_t sig_;  //<! The actual magic number
-};                // class OrfHeader
+  uint16_t sig_{0x4f52};  //<! The actual magic number
+};                        // class OrfHeader
 
 }  // namespace Exiv2::Internal
 

src/tiffimage_int.hpp

@@ -371,15 +371,15 @@ class OffsetWriter {
   //! Data structure for the offset list.
   struct OffsetData {
     //! Default constructor
-    OffsetData() : origin_(0), byteOrder_(littleEndian) {
+    OffsetData() {
     }
     //! Constructor
     OffsetData(uint32_t origin, ByteOrder byteOrder) : origin_(origin), byteOrder_(byteOrder) {
     }
     // DATA
-    uint32_t origin_;      //!< Origin address
-    uint32_t target_{};    //!< Target address
-    ByteOrder byteOrder_;  //!< Byte order to use to encode target address
+    uint32_t origin_{0};                 //!< Origin address
+    uint32_t target_{};                  //!< Target address
+    ByteOrder byteOrder_{littleEndian};  //!< Byte order to use to encode target address
   };
   //! Type of the list containing an identifier and an address pair.
   using OffsetList = std::map<OffsetId, OffsetData>;