fix most weak-vtable warnings

This might fix bogus MSVC problems with header includes.

Signed-off-by: Rosen Penev <[email protected]>

Author: neheb

include/exiv2/basicio.hpp

@@ -883,6 +883,7 @@ class EXIV2API HttpIo : public RemoteIo {
           on demand from the server, so it avoids copying the complete file.
    */
   explicit HttpIo(const std::string& url, size_t blockSize = 1024);
+  ~HttpIo() override;
 
  private:
   // Pimpl idiom

src/basicio.cpp

@@ -1473,6 +1473,8 @@ void HttpIo::HttpImpl::writeRemote(const byte* data, size_t size, size_t from, s
 HttpIo::HttpIo(const std::string& url, size_t blockSize) {
   p_ = std::make_unique<HttpImpl>(url, blockSize);
 }
+
+HttpIo::~HttpIo() = default;
 #endif
 
 #ifdef EXV_USE_CURL

src/pentaxmn_int.cpp

@@ -13,6 +13,15 @@
 #include "types.hpp"
 #include "value.hpp"
 
+#include <iomanip>
+
+namespace {
+// Exception thrown by findLensInfo when the lens info can't be found.
+class LensInfoNotFound : public std::exception {
+  using std::exception::exception;
+};
+}  // namespace
+
 // *****************************************************************************
 // class member definitions
 namespace Exiv2::Internal {
@@ -1040,11 +1049,6 @@ static long getKeyLong(const std::string& key, const ExifData* metadata) {
   return result;
 }
 
-// Exception thrown by findLensInfo when the lens info can't be found.
-class LensInfoNotFound : public std::exception {
-  using std::exception::exception;
-};
-
 // Throws std::exception if the LensInfo can't be found.
 static ExifData::const_iterator findLensInfo(const ExifData* metadata) {
   const auto dngLensInfo = metadata->findKey(ExifKey("Exif.PentaxDng.LensInfo"));

src/tiffcomposite_int.hpp

@@ -596,6 +596,8 @@ class TiffDataEntryBase : public TiffEntryBase {
   TiffDataEntryBase(uint16_t tag, IfdId group, uint16_t szTag, IfdId szGroup);
   //@}
 
+  ~TiffDataEntryBase() override;
+
   //! @name Manipulators
   //@{
   /*!

src/tiffvisitor_int.cpp

@@ -345,6 +345,8 @@ TiffDataEntryBase::TiffDataEntryBase(uint16_t tag, IfdId group, uint16_t szTag,
     TiffEntryBase(tag, group), szTag_(szTag), szGroup_(szGroup) {
 }
 
+TiffDataEntryBase::~TiffDataEntryBase() = default;
+
 void TiffDecoder::decodeCanonAFInfo(const TiffEntryBase* object) {
   // report Exif.Canon.AFInfo as usual
   TiffDecoder::decodeStdTiffEntry(object);