Merge pull request #2200 from neheb/3

clang-tidy with headers

Author: piponazo

include/exiv2/basicio.hpp

@@ -711,6 +711,9 @@ class EXIV2API XPathIo : public FileIo {
   ~XPathIo() override;
   //@}
 
+  XPathIo(const XPathIo&) = delete;
+  XPathIo& operator=(const XPathIo&) = delete;
+
   //! @name Manipulators
   //@{
   /*!
@@ -751,6 +754,9 @@ class EXIV2API RemoteIo : public BasicIo {
   ~RemoteIo() override;
   //@}
 
+  RemoteIo(const RemoteIo&) = delete;
+  RemoteIo& operator=(const RemoteIo&) = delete;
+
   //! @name Manipulators
   //@{
   /*!
@@ -920,6 +926,7 @@ class EXIV2API HttpIo : public RemoteIo {
    */
   explicit HttpIo(const std::string& url, size_t blockSize = 1024);
 
+  ~HttpIo() override = default;
   // NOT IMPLEMENTED
   //! Copy constructor
   HttpIo(const HttpIo&) = delete;
@@ -964,6 +971,7 @@ class EXIV2API CurlIo : public RemoteIo {
    */
   size_t write(BasicIo& src) override;
 
+  ~CurlIo() override = default;
   // NOT IMPLEMENTED
   //! Copy constructor
   CurlIo(const CurlIo&) = delete;

include/exiv2/bmffimage.hpp

@@ -123,7 +123,7 @@ class EXIV2API BmffImage : public Image {
     @warning This function should only be called by readMetadata()
    */
   long boxHandler(std::ostream& out, Exiv2::PrintStructureOption option, const long pbox_end, int depth);
-  [[nodiscard]] std::string indent(int i) const {
+  [[nodiscard]] static std::string indent(int i) {
     return std::string(2 * i, ' ');
   }
 

include/exiv2/bmpimage.hpp

@@ -26,6 +26,7 @@ namespace Exiv2 {
  */
 class EXIV2API BmpImage : public Image {
  public:
+  ~BmpImage() override = default;
   //! @name NOT Implemented
   //@{
   //! Copy constructor

include/exiv2/cr2image.hpp

@@ -71,6 +71,7 @@ class EXIV2API Cr2Image : public Image {
   [[nodiscard]] uint32_t pixelHeight() const override;
   //@}
 
+  ~Cr2Image() override = default;
   //! @name NOT implemented
   //@{
   //! Copy constructor

include/exiv2/crwimage.hpp

@@ -73,6 +73,7 @@ class EXIV2API CrwImage : public Image {
   [[nodiscard]] uint32_t pixelHeight() const override;
   //@}
 
+  ~CrwImage() override = default;
   //! @name NOT Implemented
   //@{
   //! Copy constructor

include/exiv2/datasets.hpp

@@ -132,6 +132,7 @@ class EXIV2API IptcDataSets {
   static constexpr uint16_t Preview = 202;
   //@}
 
+  ~IptcDataSets() = delete;
   //! Prevent copy-construction: not implemented.
   IptcDataSets(const IptcDataSets&) = delete;
   //! Prevent assignment: not implemented.
@@ -263,7 +264,7 @@ class EXIV2API IptcKey : public Key {
   IptcKey(uint16_t tag, uint16_t record);
   //! Copy constructor
   IptcKey(const IptcKey& rhs);
-  IptcKey& operator=(const IptcKey&) = delete;
+  IptcKey& operator=(const IptcKey&) = default;
   //! Destructor
   ~IptcKey() override = default;
   //@}

include/exiv2/epsimage.hpp

@@ -73,6 +73,7 @@ class EXIV2API EpsImage : public Image {
   [[nodiscard]] std::string mimeType() const override;
   //@}
 
+  ~EpsImage() override = default;
   //! @name NOT Implemented
   //@{
   //! Copy constructor

include/exiv2/gifimage.hpp

@@ -21,6 +21,7 @@ namespace Exiv2 {
  */
 class EXIV2API GifImage : public Image {
  public:
+  ~GifImage() override = default;
   //! @name NOT Implemented
   //@{
   //! Copy constructor

include/exiv2/image.hpp

@@ -656,6 +656,7 @@ class EXIV2API ImageFactory {
 
   //! @name Creators
   //@{
+  ~ImageFactory() = delete;
   //! Prevent copy construction: not implemented.
   ImageFactory(const ImageFactory&) = delete;
   ImageFactory& operator=(const ImageFactory&) = delete;

include/exiv2/jp2image.hpp

@@ -64,6 +64,7 @@ class EXIV2API Jp2Image : public Image {
   [[nodiscard]] std::string mimeType() const override;
   //@}
 
+  ~Jp2Image() override = default;
   //! @name NOT Implemented
   //@{
   //! Copy constructor